dhclient/tests: use require.kmods property instead of ad-hoc checks
Needs ReviewPublic
Actions

Authored by siva on Tue, Feb 10, 3:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 6, 4:55 AM

	Unknown Object (File)
	Tue, Mar 3, 11:27 PM

	Unknown Object (File)
	Tue, Mar 3, 7:29 AM

	Unknown Object (File)
	Mon, Feb 16, 6:11 PM

	Unknown Object (File)
	Mon, Feb 16, 11:38 AM

	Unknown Object (File)
	Thu, Feb 12, 5:19 PM

	Unknown Object (File)
	Thu, Feb 12, 4:17 AM

	Unknown Object (File)
	Thu, Feb 12, 2:33 AM

View All 13 Files

Subscribers

imp

Details

Reviewers

jmg
lwhsu

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70609
Build 67492: arc lint + arc unit

Event Timeline

siva created this revision.Tue, Feb 10, 3:44 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 10, 3:44 PM

siva requested review of this revision.Tue, Feb 10, 3:44 PM

Harbormaster completed remote builds in B70582: Diff 171676.Tue, Feb 10, 3:44 PM

I'm good for kmods part. For dhcpd, in general it's a good direction. It's a bit pity that we lost the message of needing "ISC dhcp server", as I am not sure if this test works with other dhcpd. Not sure where is the best place to put that information.

Added a comment pointing to the pkg origin of dhcpd

Harbormaster completed remote builds in B70609: Diff 171709.Tue, Feb 10, 10:26 PM