Page MenuHomeFreeBSD
Differential D6647

Let dbm's datum::dptr use the right type.
ClosedPublic
Actions

Authored by ed on May 30 2016, 1:59 PM.
Tags
None
Referenced Files
F172507256: D6647.id17108.diff
Fri, Sep 18, 10:31 PM
F172503987: D6647.id17117.diff
Fri, Sep 18, 10:03 PM
F172485783: D6647.diff
Fri, Sep 18, 7:25 PM
F172463938: D6647.id.diff
Fri, Sep 18, 3:59 PM
Unknown Object (File)
Sun, Sep 13, 4:23 PM
Unknown Object (File)
Sun, Aug 23, 6:17 PM
Unknown Object (File)
Aug 19 2026, 9:01 AM
Unknown Object (File)
Aug 19 2026, 9:01 AM
View All Files
Subscribers
imp

Details

Reviewers
pfg
Group Reviewers
manpages
Commits
rS300999: Let dbm's datum::dptr use the right type.
Summary

According to POSIX, it should use void *, not char *. Unfortunately, the
dsize field also has the wrong type. It should be size_t. I'm not going
to change that, as that will break the ABI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ed updated this revision to Diff 17108.May 30 2016, 1:59 PM
ed retitled this revision from to Let dbm's datum::dptr use the right type..
ed updated this object.
ed edited the test plan for this revision. (Show Details)
ed added a reviewer: pfg.
Herald added a reviewer: manpages. · View Herald TranscriptMay 30 2016, 1:59 PM
Herald added a subscriber: imp. · View Herald Transcript
pfg accepted this revision.May 30 2016, 4:14 PM
pfg edited edge metadata.

Modernity :).

This revision is now accepted and ready to land.May 30 2016, 4:14 PM
Closed by commit rS300999: Let dbm's datum::dptr use the right type. (authored by ed). · Explain WhyMay 30 2016, 4:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
include/
2 lines
lib/
libc/
db/
man/
4 lines

Diff 17117

View Options

head/include/ndbm.h

Loading...
View Options

head/lib/libc/db/man/dbm.3

Loading...