Page MenuHomeFreeBSD
Differential D55088

LinuxKPI: string_choices.h: use ternary operator
ClosedPublic
Actions

Authored by bz on Tue, Feb 3, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 5, 11:31 PM
Unknown Object (File)
Tue, Feb 3, 7:11 PM
Subscribers
imp

Details

Reviewers
emaste
kib
Group Reviewers
linuxkpi
Commits
rG8df7af9c9ecf: LinuxKPI: string_choices.h: use ternary operator
Summary

Switch from using if () else to a direct return (?:) code.
No functional changes.

Suggested by: kib (D55029)
Sponosred by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70378
Build 67261: arc lint + arc unit

Event Timeline

bz created this revision.Tue, Feb 3, 6:52 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 3, 6:52 PM
bz requested review of this revision.Tue, Feb 3, 6:52 PM
Harbormaster completed remote builds in B70378: Diff 171099.Tue, Feb 3, 6:52 PM
emaste accepted this revision.Tue, Feb 3, 7:09 PM

OK. The parens on (value) aren't needed though.

This revision is now accepted and ready to land.Tue, Feb 3, 7:09 PM
bz added a comment.Tue, Feb 3, 7:56 PM
In D55088#1259109, @emaste wrote:

OK. The parens on (value) aren't needed though.

removed before push.

Closed by commit rG8df7af9c9ecf: LinuxKPI: string_choices.h: use ternary operator (authored by bz). · Explain WhyTue, Feb 3, 8:01 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG8df7af9c9ecf: LinuxKPI: string_choices.h: use ternary operator.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
25 lines

Diff 171099

View Options

sys/compat/linuxkpi/common/include/linux/string_choices.h

Loading...