Page MenuHomeFreeBSD
Differential D55055

ifinfo: Print names of CSUM bits
ClosedPublic
Actions

Authored by timo.voelker_fh-muenster.de on Feb 2 2026, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 6:27 AM
Unknown Object (File)
Fri, Sep 4, 7:05 PM
Unknown Object (File)
Fri, Sep 4, 5:05 PM
Unknown Object (File)
Fri, Sep 4, 12:36 PM
Unknown Object (File)
Fri, Sep 4, 10:13 AM
Unknown Object (File)
Fri, Sep 4, 9:43 AM
Unknown Object (File)
Fri, Sep 4, 3:33 AM
Unknown Object (File)
Wed, Sep 2, 9:21 AM
View All Files
Subscribers
imp

Details

Reviewers
wollman
tuexen
Commits
rGd3234683f88d: ifinfo: improve output of hwassist value
rGc0178169207d: ifinfo: improve output of hwassist value
rGd84870d90baf: ifinfo: improve output of hwassist value
Summary

ifinfo prints the value of if_hwassist. The value is hard to read since it is a bitmap for CSUM_* bits defined in src/sys/sys/mbuf.h. With this patch, ifinfo additionally prints the names of the CSUM_* bits.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

timo.voelker_fh-muenster.de created this revision.Feb 2 2026, 4:49 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2026, 4:49 PM
timo.voelker_fh-muenster.de requested review of this revision.Feb 2 2026, 4:49 PM
tuexen added inline comments.Feb 2 2026, 6:43 PM
tools/tools/ifinfo/ifinfo.c
162

first is used as a boolean. Can't you use bool first instead of int first?

timo.voelker_fh-muenster.de marked an inline comment as done.Feb 3 2026, 9:29 AM
timo.voelker_fh-muenster.de added inline comments.
tools/tools/ifinfo/ifinfo.c
162

bool seems not to be available as a data type when building a tool.

timo.voelker_fh-muenster.de updated this revision to Diff 171061.Feb 3 2026, 1:56 PM
timo.voelker_fh-muenster.de marked an inline comment as done.

Use CSUM_BITS string defined in sys/mbuf.h for output.

Use bool type, which is possible after adding #include <ctype.h>

tuexen accepted this revision.Feb 3 2026, 2:22 PM
This revision is now accepted and ready to land.Feb 3 2026, 2:22 PM
Closed by commit rGd84870d90baf: ifinfo: improve output of hwassist value (authored by timo.voelker_fh-muenster.de, committed by tuexen). · Explain WhyFeb 8 2026, 8:06 PM
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGd84870d90baf: ifinfo: improve output of hwassist value.
tuexen added a commit: rGc0178169207d: ifinfo: improve output of hwassist value.Apr 25 2026, 7:26 PM
tuexen added a commit: rGd3234683f88d: ifinfo: improve output of hwassist value.Apr 26 2026, 8:25 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
ifinfo/
27 lines

Diff 170992

View Options

tools/tools/ifinfo/ifinfo.c

Loading...