Differential D55011

libc/resolv: Switch default to loopback address
ClosedPublic
Actions

Authored by des on Sat, Jan 31, 12:00 PM.

Tags

None

Referenced Files

	F145180103: D55011.id170846.diff
	Mon, Feb 16, 8:11 PM

	Unknown Object (File)
	Mon, Feb 16, 12:23 PM

	Unknown Object (File)
	Sat, Feb 14, 9:13 PM

	Unknown Object (File)
	Sun, Feb 8, 8:18 AM

	Unknown Object (File)
	Sat, Feb 7, 10:17 AM

	Unknown Object (File)
	Sun, Feb 1, 9:14 PM

	Unknown Object (File)
	Sun, Feb 1, 11:50 AM

	Unknown Object (File)
	Sun, Feb 1, 10:12 AM

View All 17 Files

Subscribers

Details

Reviewers

Commits

rG6b0a4d67a952: libc/resolv: Switch default to loopback address
rGc137555c3f39: libc/resolv: Switch default to loopback address
rG1538284a5fdd: libc/resolv: Switch default to loopback address

Summary

If no resolver configuration was found, we would fall back to INADDR_ANY
and IN6ADDR_ANY. This made sense when it was first written thirty or
forty years ago but not today, especially since connecting to INADDR_ANY
or IN6ADDR_ANY is no longer supported. Switch to the loopback address
and simplify the code.

Note that (as the pre-existing comment in the code states) running
without a resolver configuration is not really supported. Still, if
we're going to have a hardcoded fallback, it might as well work.

PR: 291790
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70283
Build 67166: arc lint + arc unit

Event Timeline

des created this revision.Sat, Jan 31, 12:00 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jan 31, 12:00 PM

des requested review of this revision.Sat, Jan 31, 12:00 PM

Harbormaster completed remote builds in B70283: Diff 170846.Sat, Jan 31, 12:00 PM

fix IPv4 address

Harbormaster completed remote builds in B70284: Diff 170847.Sat, Jan 31, 12:18 PM

emaste added a subscriber: emaste.Sat, Jan 31, 1:15 PM

kevans accepted this revision.Sat, Jan 31, 3:33 PM

This revision is now accepted and ready to land.Sat, Jan 31, 3:33 PM

Closed by commit rG1538284a5fdd: libc/resolv: Switch default to loopback address (authored by des). · Explain WhySat, Jan 31, 5:55 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG1538284a5fdd: libc/resolv: Switch default to loopback address.

des added a commit: rGc137555c3f39: libc/resolv: Switch default to loopback address.Thu, Feb 5, 2:38 PM

des added a commit: rG6b0a4d67a952: libc/resolv: Switch default to loopback address.

Revision Contents
Changeset List

Path

Size

lib/

libc/

resolv/

67 lines

Diff 170846

lib/libc/resolv/res_init.c

Loading...