Page MenuHomeFreeBSD
Differential D54955

firmware: Fix inverted FIRMWARE_GET_NOWARN logic
ClosedPublic
Actions

Authored by guest-seuros on Jan 29 2026, 11:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 7, 5:22 PM
Unknown Object (File)
Wed, Apr 1, 7:35 PM
Unknown Object (File)
Wed, Mar 25, 9:24 AM
Unknown Object (File)
Wed, Mar 25, 7:37 AM
Unknown Object (File)
Wed, Mar 25, 7:14 AM
Unknown Object (File)
Sun, Mar 22, 4:19 AM
Unknown Object (File)
Fri, Mar 20, 3:43 AM
Unknown Object (File)
Fri, Mar 20, 3:43 AM
View All 29 Files
Subscribers
imp
olce

Details

Reviewers
kevans
Commits
rGfdcd67be8274: firmware: Fix inverted FIRMWARE_GET_NOWARN logic
Summary

The try_binary_file() function has inverted logic for the FIRMWARE_GET_NOWARN flag.
When the flag is set (meaning "don't warn"), the code sets warn=true and makes noise anyway.

Rename the variable to nowarn and invert the check to correctly suppress warnings when FIRMWARE_GET_NOWARN is set.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70220
Build 67103: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Jan 29 2026, 11:02 PM
guest-seuros held this revision as a draft.
Herald added subscribers: olce, imp. · View Herald TranscriptJan 29 2026, 11:02 PM
Harbormaster completed remote builds in B70220: Diff 170752.Jan 29 2026, 11:02 PM
guest-seuros published this revision for review.Jan 29 2026, 11:03 PM
guest-seuros edited the summary of this revision. (Show Details)
guest-seuros added a reviewer: kevans.
kevans added inline comments.Jan 29 2026, 11:07 PM
sys/kern/subr_firmware.c
341

I think this would read a bit better after it was still named warn and we just fixed the logic above and here; double-negatives are kind of not great

guest-seuros updated this revision to Diff 170754.Jan 29 2026, 11:23 PM

Address review feedback: keep warn variable, invert at assignment instead of double-negative

Harbormaster completed remote builds in B70222: Diff 170754.Jan 29 2026, 11:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 30 2026, 12:03 AM
Closed by commit rGfdcd67be8274: firmware: Fix inverted FIRMWARE_GET_NOWARN logic (authored by guest-seuros, committed by kevans). · Explain Why
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGfdcd67be8274: firmware: Fix inverted FIRMWARE_GET_NOWARN logic.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 170752

View Options

sys/kern/subr_firmware.c

Loading...