Stop using the non-standard basename_r() function.
ClosedPublic
Actions

Authored by ed on May 29 2016, 9:57 AM.

Details

Reviewers

gjb
hrs

Commits

rS301024: Stop using the non-standard basename_r() function.

Summary

This change makes the code use the POSIX basename() function. It has the
advantage that (if implemented correctly), it also imposes no restrict
on the pathname length.

Notice that I haven't added any error handling to the strdup() call. It
looks like none of the other calls to strdup() and malloc() performed by
this utility do it either.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4015
Build 4058: arc lint + arc unit

Event Timeline

ed updated this revision to Diff 17061.May 29 2016, 9:57 AM

ed retitled this revision from to Stop using the non-standard basename_r() function..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added reviewers: hrs, gjb.

Herald added a subscriber: imp. · View Herald TranscriptMay 29 2016, 9:57 AM

Looks good to me. Do we need strdup(), BTW? I think FreeBSD's basename() does not change
memory area where name points though SUS says it may be changed.

This revision is now accepted and ready to land.May 31 2016, 4:05 AM

In D6626#140418, @hrs wrote:

Looks good to me. Do we need strdup(), BTW? I think FreeBSD's basename() does not change
memory area where name points though SUS says it may be changed.

My plan is to switch over to the POSIX prototype in 12.0-CURRENT. ;-)

In D6626#140434, @ed wrote:

In D6626#140418, @hrs wrote:

Looks good to me. Do we need strdup(), BTW? I think FreeBSD's basename() does not change
memory area where name points though SUS says it may be changed.

My plan is to switch over to the POSIX prototype in 12.0-CURRENT. ;-)

Ah, I see. So please go ahead with your original patch.

Closed by commit rS301024: Stop using the non-standard basename_r() function. (authored by ed). · Explain WhyMay 31 2016, 6:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sbin/

swapon/

swapon.c

14 lines

Diff 17061

View Options

Stop using the non-standard basename_r() function.ClosedPublicActions