Page MenuHomeFreeBSD
Differential D54861

LinuxKPI: pci: make sure a tailq and lock are initialized
Needs ReviewPublic
Actions

Authored by bz on Sat, Jan 24, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 1, 1:49 AM
Unknown Object (File)
Tue, Jan 27, 3:40 PM
Unknown Object (File)
Sun, Jan 25, 12:31 PM
Unknown Object (File)
Sun, Jan 25, 10:30 AM
Unknown Object (File)
Sun, Jan 25, 7:12 AM
Unknown Object (File)
Sun, Jan 25, 5:02 AM
Unknown Object (File)
Sun, Jan 25, 4:22 AM
Unknown Object (File)
Sun, Jan 25, 12:49 AM
Subscribers
emaste
imp

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

Move the initializations of the tailq, and lock from
linux_pci_attach_device() into lkpifill_pci_dev() so that they are
initialized in all cases we create a device (see all the possible
callers of lkpifill_pci_dev()).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

I hit one of these cases last year in December but I lost
track under which circumstances as the change was just
hanging along D.54841.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70117
Build 67000: arc lint + arc unit

Event Timeline

bz created this revision.Sat, Jan 24, 10:20 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptSat, Jan 24, 10:20 PM
bz requested review of this revision.Sat, Jan 24, 10:20 PM
Harbormaster completed remote builds in B70117: Diff 170354.Sat, Jan 24, 10:20 PM
bz added inline comments.Sat, Jan 24, 10:34 PM
sys/compat/linuxkpi/common/src/linux_pci.c
388

The move of this line is unrelated to the change but it made sense to group them together below.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
7 lines

Diff 170354

View Options

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...