Page MenuHomeFreeBSD
Differential D54810

LinuxKPI: implement dmam_free_coherent()
AcceptedPublic
Actions

Authored by bz on Wed, Jan 21, 2:00 PM.
Tags
None
Referenced Files
F142976084: D54810.diff
Sun, Jan 25, 1:19 AM
F142947771: D54810.diff
Sat, Jan 24, 9:32 PM
Unknown Object (File)
Sat, Jan 24, 9:08 AM
Unknown Object (File)
Fri, Jan 23, 4:51 AM
Unknown Object (File)
Fri, Jan 23, 1:17 AM
Unknown Object (File)
Fri, Jan 23, 12:19 AM
Unknown Object (File)
Wed, Jan 21, 2:27 PM
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Summary

dmam_free_coherent() is used by an updated mt76 driver at v6.19-rc6.
We need to surgically find the devres information and destroy it before
calling dma_free_coherent.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 70039
Build 66922: arc lint + arc unit

Event Timeline

bz created this revision.Wed, Jan 21, 2:00 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptWed, Jan 21, 2:00 PM
bz requested review of this revision.Wed, Jan 21, 2:00 PM
Harbormaster completed remote builds in B70039: Diff 170182.Wed, Jan 21, 2:00 PM
emaste added a comment.Wed, Jan 21, 7:34 PM

Why do we use linuxkpi prefix sometimes and lkpi others?

But looks fine

bz added a comment.Wed, Jan 21, 8:04 PM
In D54810#1252993, @emaste wrote:

Why do we use linuxkpi prefix sometimes and lkpi others?

But looks fine

Historically this was mixed. We are trying to use linuxkpi_ for official public LinuxKPi functions now and lkpi_ for internal. Historically there's also linux_ which we shoudl leave to the Linuxolator. Doing the full sweep one day will be tough but at least trying to keep it consistent for new stuff.

Should we add a README somewhere in sys/compat/linuxkpi/ and start writing these things down?

imp added a comment.Wed, Jan 21, 8:07 PM
In D54810#1253014, @bz wrote:
In D54810#1252993, @emaste wrote:

Why do we use linuxkpi prefix sometimes and lkpi others?

But looks fine

Historically this was mixed. We are trying to use linuxkpi_ for official public LinuxKPi functions now and lkpi_ for internal. Historically there's also linux_ which we shoudl leave to the Linuxolator. Doing the full sweep one day will be tough but at least trying to keep it consistent for new stuff.

Should we add a README somewhere in sys/compat/linuxkpi/ and start writing these things down?

I love that idea

bz added a comment.Wed, Jan 21, 8:10 PM

Should we add a README somewhere in sys/compat/linuxkpi/ and start writing these things down?

I love that idea

Great. I'll find the version I wrote in ~2021, when people didn't like, the next days it and update it and put it up here.

emaste accepted this revision as: emaste.Wed, Jan 21, 8:12 PM

OK with me

This revision is now accepted and ready to land.Wed, Jan 21, 8:12 PM
bz added inline comments.Sun, Jan 25, 12:20 AM
sys/compat/linuxkpi/common/src/linux_pci.c
1822

= &dma_handle ; will do before commit.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
9 lines
src/
36 lines

Diff 170182

View Options

sys/compat/linuxkpi/common/include/linux/dma-mapping.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...