Page MenuHomeFreeBSD
Differential D54747

Mk/Uses/gssapi: Add support for mit-devel
ClosedPublic
Actions

Authored by cy on Fri, Jan 16, 7:16 PM.
Tags
None
Referenced Files
F142569729: D54747.diff
Wed, Jan 21, 3:12 AM
Unknown Object (File)
Mon, Jan 19, 3:32 PM
Unknown Object (File)
Sun, Jan 18, 1:41 AM
Unknown Object (File)
Sat, Jan 17, 7:14 PM
Unknown Object (File)
Sat, Jan 17, 5:18 AM
Unknown Object (File)
Sat, Jan 17, 3:37 AM
Unknown Object (File)
Sat, Jan 17, 1:51 AM
Unknown Object (File)
Sat, Jan 17, 1:26 AM
View All 13 Files
Subscribers
dan.mcgregor_usask.ca

Details

Reviewers
hrs
michaelo
Commits
R11:95035ba60352: Mk/Uses/gssapi: Add support for mit-devel
Summary

Add support for security/krb5-devel.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69935
Build 66818: arc lint + arc unit

Event Timeline

cy requested review of this revision.Fri, Jan 16, 7:16 PM
cy created this revision.
Harbormaster completed remote builds in B69932: Diff 169868.Fri, Jan 16, 7:17 PM
cy added a reviewer: michaelo.Fri, Jan 16, 7:18 PM
michaelo added a comment.Fri, Jan 16, 7:28 PM

What about the documentation part? It does not mention mit-devel at all.

cy updated this revision to Diff 169908.Fri, Jan 16, 8:00 PM

Added documentation for mit-devel.

Harbormaster completed remote builds in B69935: Diff 169908.Fri, Jan 16, 8:00 PM
michaelo requested changes to this revision.Fri, Jan 16, 8:13 PM
michaelo added inline comments.
Mk/Uses/gssapi.mk
54

For the sake of completion mit-devel should have its block here too. Don't forget to create the _DESC make var.

This revision now requires changes to proceed.Fri, Jan 16, 8:13 PM
cy updated this revision to Diff 169913.Fri, Jan 16, 9:12 PM

Added additional documentation.

Added GSSAPI_MIT_DEVEL descriptions.

Harbormaster completed remote builds in B69939: Diff 169913.Fri, Jan 16, 9:12 PM
michaelo accepted this revision.Fri, Jan 16, 9:49 PM

LGTM

This revision is now accepted and ready to land.Fri, Jan 16, 9:49 PM
Closed by commit R11:95035ba60352: Mk/Uses/gssapi: Add support for mit-devel (authored by cy). · Explain WhyMon, Jan 19, 2:45 PM
This revision was automatically updated to reflect the committed changes.
cy added a commit: R11:95035ba60352: Mk/Uses/gssapi: Add support for mit-devel.
dan.mcgregor_usask.ca added a subscriber: dan.mcgregor_usask.ca.Mon, Jan 19, 4:26 PM
dan.mcgregor_usask.ca added inline comments.
Mk/Uses/gssapi.mk
127

This is shell style syntax, not make syntax. This should be || instead of -o.

dan.mcgregor_usask.ca added a comment.Mon, Jan 19, 4:27 PM

Nevermind, looks like it was reported by somebody else first ;)

Revision Contents
Changeset List

PathSize
Mk/
Uses/
7 lines

Diff 169908

View Options

Mk/Uses/gssapi.mk

Loading...