linuxkpi: Fix an error path in linux_alloc_current()
ClosedPublic
Actions

Authored by markj on Mon, Jan 12, 6:56 PM.

Details

Reviewers

emaste

Group Reviewers

linuxkpi

Commits

rG72dc1a15d8f7: linuxkpi: Fix an error path in linux_alloc_current()
rGa4955b014336: linuxkpi: Fix an error path in linux_alloc_current()

Summary

If the allocation fails we should free the task struct.

While here get rid of a strange assertion.

Reported by: Kevin Day <kevin@your.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Jan 12, 6:56 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Jan 12, 6:56 PM

markj requested review of this revision.Mon, Jan 12, 6:56 PM

markj added a child revision: D54672: linuxkpi: Avoid a potential null pointer dereference in an error path.

Harbormaster completed remote builds in B69829: Diff 169533.Wed, Jan 14, 12:50 AM

There's the same assertion earlier in the fn for the ts allocation.

This revision is now accepted and ready to land.Wed, Jan 14, 4:32 PM

In D54671#1249971, @emaste wrote:

There's the same assertion earlier in the fn for the ts allocation.

Thanks, I'll get rid of that one too.

Closed by commit rGa4955b014336: linuxkpi: Fix an error path in linux_alloc_current() (authored by markj). · Explain WhyThu, Jan 15, 2:20 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa4955b014336: linuxkpi: Fix an error path in linux_alloc_current().

markj added a commit: rG72dc1a15d8f7: linuxkpi: Fix an error path in linux_alloc_current().Mon, Jan 26, 12:53 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_current.c

10 lines

Diff 169775

View Options

sys/compat/linuxkpi/common/src/linux_current.c

linuxkpi: Fix an error path in linux_alloc_current()ClosedPublicActions