exterr: Sort output from make_libc_exterr_cat_filenames.sh
ClosedPublic
Actions

Authored by markj on Jan 12 2026, 5:54 PM.

Details

Reviewers

Commits

rG36daea2a6da0: exterr: Sort output from make_libc_exterr_cat_filenames.sh
rGbda6ed2ee4d8: exterr: Sort output from make_libc_exterr_cat_filenames.sh

Summary

Otherwise the script may permute the order of entries in the file since
find(1) output is not stable.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69827
Build 66710: arc lint + arc unit

Event Timeline

markj created this revision.Jan 12 2026, 5:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 12 2026, 5:54 PM

markj requested review of this revision.Jan 12 2026, 5:54 PM

Harbormaster completed remote builds in B69827: Diff 169530.Jan 14 2026, 12:50 AM

I also noted it, but used find | sort in D54592.

Feel free to commit. I think you want to split the commit of script and the commit of the regenerated file, to be able to MFC without conflicts.

kib accepted this revision.Jan 14 2026, 4:03 PM

This revision is now accepted and ready to land.Jan 14 2026, 4:03 PM

Closed by commit rGbda6ed2ee4d8: exterr: Sort output from make_libc_exterr_cat_filenames.sh (authored by markj). · Explain WhyJan 16 2026, 3:59 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbda6ed2ee4d8: exterr: Sort output from make_libc_exterr_cat_filenames.sh.

markj added a commit: rG36daea2a6da0: exterr: Sort output from make_libc_exterr_cat_filenames.sh.Mon, Jan 26, 12:53 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

exterr_cat_filenames.h

tools/

build/

make_libc_exterr_cat_filenames.sh

2 lines

Diff 169530

View Options

lib/libc/gen/exterr_cat_filenames.h