Page MenuHomeFreeBSD
Differential D54617

acpi_battery: Convert driver to CTLFLAG_MPSAFE
Needs ReviewPublic
Actions

Authored by guest-seuros on Jan 9 2026, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 1, 4:28 PM
Unknown Object (File)
Thu, Feb 19, 8:01 AM
Unknown Object (File)
Jan 30 2026, 8:47 PM
Unknown Object (File)
Jan 27 2026, 7:58 PM
Unknown Object (File)
Jan 19 2026, 11:47 PM
Unknown Object (File)
Jan 19 2026, 4:29 PM
Unknown Object (File)
Jan 18 2026, 11:39 PM
Unknown Object (File)
Jan 18 2026, 12:01 PM
View All 19 Files
Subscribers
None

Details

Reviewers
jhb
imp
markj
Summary

Replaced CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all battery status sysctls.

The driver uses ACPI_SERIAL locks for correct synchronization and does not require Giant lock.

Test Plan

hw.acpi.battery.* were functional after the conversion.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

guest-seuros requested review of this revision.Jan 9 2026, 3:22 PM
guest-seuros created this revision.
markj added a comment.Jan 12 2026, 12:47 AM

acpi_battery_get_battinfo() calls into the newbus layer and accesses some structures that are synchronized by the Giant lock. I think we need to at least acquire bus_topo_lock() in acpi_battery_get_battinfo().

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
10 lines

Diff 169388

View Options

sys/dev/acpica/acpi_battery.c

Loading...