Page MenuHomeFreeBSD
Differential D54470

cam: When inq data isn't valid, pass NULL
ClosedPublic
Actions

Authored by imp on Jan 3 2026, 10:53 AM.
Tags
None
Referenced Files
F163429762: D54470.id169296.diff
Thu, Jul 23, 3:34 AM
F163399232: D54470.id169296.diff
Wed, Jul 22, 8:58 PM
Unknown Object (File)
Sat, Jul 18, 9:38 PM
Unknown Object (File)
Sat, Jul 18, 12:41 PM
Unknown Object (File)
Fri, Jul 17, 8:01 AM
Unknown Object (File)
Wed, Jul 15, 7:00 AM
Unknown Object (File)
Wed, Jul 15, 7:00 AM
Unknown Object (File)
Thu, Jul 9, 8:28 PM
View All 45 Files
Subscribers
None

Details

Reviewers
adrian
Group Reviewers
cam
Commits
rGaaec2a90b5ce: cam: When inq data isn't valid, pass NULL
Summary

When the device isn't there, we don't have valid inq data. Pass NULL in
this case. All the routines that receive this test against NULL already.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jan 3 2026, 10:53 AM
Herald added a reviewer: cam. · View Herald TranscriptJan 3 2026, 10:53 AM
imp requested review of this revision.Jan 3 2026, 10:53 AM
Harbormaster completed remote builds in B69585: Diff 168954.Jan 3 2026, 10:53 AM
imp added a parent revision: D54469: cam: Add probes for xpt actions.Jan 3 2026, 10:53 AM
imp added a child revision: D54471: dtrace: Add definitiosn for the cam dtrace provider.
imp added a reviewer: adrian.Jan 3 2026, 10:55 AM
adrian added inline comments.Jan 3 2026, 5:43 PM
share/man/man4/Makefile
1012 ↗(On Diff #168954)

Doesn't this belong in the previous commit?

adrian accepted this revision.Jan 3 2026, 5:48 PM

accepting; save the manpage include, please shuffle that :p

This revision is now accepted and ready to land.Jan 3 2026, 5:48 PM
imp added inline comments.Jan 3 2026, 6:21 PM
share/man/man4/Makefile
1012 ↗(On Diff #168954)

Indeed it does.

Closed by commit rGaaec2a90b5ce: cam: When inq data isn't valid, pass NULL (authored by imp). · Explain WhyJan 8 2026, 6:26 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGaaec2a90b5ce: cam: When inq data isn't valid, pass NULL.

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
18 lines

Diff 169296

View Options

sys/cam/scsi/scsi_all.c

Loading...