Differential D54470

cam: When inq data isn't valid, pass NULL
ClosedPublic
Actions

Authored by imp on Jan 3 2026, 10:53 AM.

Details

Reviewers

adrian

Group Reviewers

cam

Commits

rGaaec2a90b5ce: cam: When inq data isn't valid, pass NULL

Summary

When the device isn't there, we don't have valid inq data. Pass NULL in
this case. All the routines that receive this test against NULL already.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 3 2026, 10:53 AM

Herald added a reviewer: cam. · View Herald TranscriptJan 3 2026, 10:53 AM

imp requested review of this revision.Jan 3 2026, 10:53 AM

Harbormaster completed remote builds in B69585: Diff 168954.Jan 3 2026, 10:53 AM

imp added a parent revision: D54469: cam: Add probes for xpt actions.Jan 3 2026, 10:53 AM

imp added a child revision: D54471: dtrace: Add definitiosn for the cam dtrace provider.

imp added a reviewer: adrian.Jan 3 2026, 10:55 AM

adrian added inline comments.Jan 3 2026, 5:43 PM

share/man/man4/Makefile
1012 ↗	(On Diff #168954)	Doesn't this belong in the previous commit?

accepting; save the manpage include, please shuffle that :p

This revision is now accepted and ready to land.Jan 3 2026, 5:48 PM

imp added inline comments.Jan 3 2026, 6:21 PM

share/man/man4/Makefile
1012 ↗	(On Diff #168954)	Indeed it does.

Closed by commit rGaaec2a90b5ce: cam: When inq data isn't valid, pass NULL (authored by imp). · Explain WhyJan 8 2026, 6:26 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGaaec2a90b5ce: cam: When inq data isn't valid, pass NULL.

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

scsi_all.c

18 lines

Diff 169296

View Options

cam: When inq data isn't valid, pass NULLClosedPublicActions