Paths

Table of Contentst

Differential D54475

nvme: Be more correct in busdma usage
Needs ReviewPublic
Actions

Authored by imp on Jan 3 2026, 6:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 5:30 AM

	Unknown Object (File)
	Fri, Sep 4, 11:03 PM

	Unknown Object (File)
	Mon, Aug 24, 5:47 PM

	Unknown Object (File)
	Sun, Aug 23, 7:56 PM

	Unknown Object (File)
	Fri, Aug 21, 2:28 AM

	Unknown Object (File)
	Sat, Aug 15, 4:19 AM

	Unknown Object (File)
	Fri, Aug 14, 5:12 PM

	Unknown Object (File)
	Fri, Aug 14, 5:12 PM

View All 96 Files

Subscribers

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Only do a PRE/POST sync for READ or WRITE, but not both. Only do a PRE
sync for requests with payloads.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69590
Build 66473: arc lint + arc unit

Event Timeline

imp created this revision.Jan 3 2026, 6:13 PM

Herald added a subscriber: dab. · View Herald TranscriptJan 3 2026, 6:13 PM

imp requested review of this revision.Jan 3 2026, 6:13 PM

Harbormaster completed remote builds in B69590: Diff 168965.Jan 3 2026, 6:13 PM

mmel added a subscriber: mmel.Jan 3 2026, 6:30 PM

mmel removed a subscriber: mmel.Jan 3 2026, 7:28 PM

mmel added inline comments.

sys/dev/nvme/nvme_qpair.c
1070	This fragment looks wrong.

imp added inline comments.Jan 3 2026, 8:24 PM

sys/dev/nvme/nvme_qpair.c
1070	This fragment looks wrong. What looks wrong?

fix the little oops that mmel found

Harbormaster completed remote builds in B69594: Diff 168976.Jan 3 2026, 10:54 PM

OK. Updated a while ago...

sys/dev/nvme/nvme_qpair.c
1070	Oh! Doh! queuemap, not payload. Fixing. Thanks!

rebase and maybe push the fixes that mmel wanted

Harbormaster completed remote builds in B72533: Diff 176433.Apr 24 2026, 8:49 PM

chuck added a subscriber: chuck.Apr 24 2026, 9:13 PM

chuck added inline comments.

sys/dev/nvme/nvme_private.h
118	Should there still be a `spare[1]` in the structure?

imp added inline comments.Apr 24 2026, 10:12 PM

sys/dev/nvme/nvme_private.h
118	I don't think it really matters. IIRC, someone suggested just removing it on IRC. But looking at this in light of some other recent changes that create read/write payloads (but never to the same dmamap)... I'll worry about that as those other changes evolve. Anyway, I added it back.

review from chuck

Harbormaster completed remote builds in B72536: Diff 176438.Apr 24 2026, 11:35 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

10 lines

nvme_ctrlr_cmd.c

4 lines

7 lines

2 lines

19 lines

3 lines

Diff 168965

sys/dev/nvme/nvme_ctrlr.c

Loading...

sys/dev/nvme/nvme_ctrlr_cmd.c

Loading...

sys/dev/nvme/nvme_ns_cmd.c

Loading...

sys/dev/nvme/nvme_private.h

Loading...

sys/dev/nvme/nvme_qpair.c

Loading...

sys/dev/nvme/nvme_sim.c

Loading...