Page MenuHomeFreeBSD
Differential D54457

df: Cleanup and refactor
Needs ReviewPublic
Actions

Authored by jlduran on Jan 2 2026, 7:56 PM.
Tags
None
Referenced Files
F167318099: D54457.id173083.diff
Thu, Aug 20, 9:07 PM
F167296032: D54457.id168931.diff
Thu, Aug 20, 6:07 PM
F167293348: D54457.id172973.diff
Thu, Aug 20, 5:37 PM
F167272960: D54457.id168896.diff
Thu, Aug 20, 1:51 PM
F167269418: D54457.id172986.diff
Thu, Aug 20, 1:11 PM
Unknown Object (File)
Wed, Aug 19, 9:56 PM
Unknown Object (File)
Wed, Aug 19, 4:01 PM
Unknown Object (File)
Tue, Aug 18, 9:02 PM
View All 97 Files
Subscribers
imp

Details

Reviewers
des
Summary

Improve code style and type safety:

  • Change boolean flags from int to bool type for clarity
  • Given sys/param.h is already included, use the MAX() macro it provides
  • Update variable types from int to size_t
  • Adjust string comparison logic for better readability
  • Add --libxo to usage message
  • Various style(9) fixes

No functional changes intended.

Suggested by: des

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jlduran created this revision.Jan 2 2026, 7:56 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 2 2026, 7:56 PM
jlduran requested review of this revision.Jan 2 2026, 7:56 PM
Harbormaster completed remote builds in B69573: Diff 168896.Jan 2 2026, 7:56 PM
jlduran added a child revision: D54264: df: ceil() the percentage value.Jan 2 2026, 8:00 PM
jlduran added a parent revision: D54016: df: Import tests from NetBSD.
jlduran added a reviewer: des.Jan 2 2026, 8:05 PM
jlduran mentioned this in D54265: df: Fix the header when using the -P option.Jan 2 2026, 8:17 PM
jlduran updated this revision to Diff 168931.Jan 3 2026, 2:11 AM
  • Remove stray reference to availheader
des added inline comments.Feb 28 2026, 10:27 AM
bin/df/df.c
60–66
285
305
466–467
483–484
588–589
603–608
614–617

otherwise it returns 0 for 0

jlduran updated this revision to Diff 172973.Mar 1 2026, 6:18 PM
jlduran marked 8 inline comments as done.
jlduran edited the summary of this revision. (Show Details)

Address suggestions

des added inline comments.Mar 1 2026, 7:23 PM
bin/df/df.c
38–41
86–87

these should all be bool, you'll have to change makevfslist() and checkvfsname() to suit.

163

I'm not sure lflag is actually needed, we can just check whether vfslist_l is null like we do for vfslist_t.

295–296

this lets you drop the cast in the malloc() call below

308
309–310

this should be fatal, imo

369

should mntsize be size_t?

371–372
493–496
614–617

actually I was mistaken, I missed that the if above used <= instead of <... either revert this or change the if (and update the comment).

jlduran updated this revision to Diff 172986.Mar 1 2026, 9:37 PM
jlduran marked 9 inline comments as done.
jlduran edited the summary of this revision. (Show Details)

Address suggestions.

bin/df/df.c
309–310

Will be addressed in a separate revision, as it is a functional change.

jlduran added a child revision: D55610: df: Make warning failures fatal.Mar 1 2026, 9:54 PM
jlduran marked an inline comment as done.
jlduran added inline comments.
bin/df/df.c
309–310

Addressed in https://reviews.freebsd.org/D55610

jlduran updated this revision to Diff 173083.Mar 3 2026, 8:34 PM
jlduran edited the summary of this revision. (Show Details)
  • Add --libxo to usage message

Revision Contents
Changeset List

PathSize
bin/
df/
54 lines

Diff 168931

View Options

bin/df/df.c

Loading...