jemalloc: avoid clash with C23 unreachable() macro
ClosedPublic
Actions

Authored by fuz on Thu, Nov 27, 10:17 PM.

Details

Reviewers

imp
markj

Commits

rG04d000a378b0: jemalloc: avoid clash with C23 unreachable() macro

Summary

This avoids a clash with the new macro in <stddef.h> introduced in D53967

Test Plan

buildworld runs fine with this change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 68905
Build 65788: arc lint + arc unit

Event Timeline

fuz requested review of this revision.Thu, Nov 27, 10:17 PM

fuz created this revision.

Harbormaster completed remote builds in B68905: Diff 167216.Thu, Nov 27, 10:17 PM

fuz added a child revision: D53967: stddef.h: add unreachable() for C23 compliance.Thu, Nov 27, 10:17 PM

Ideally, you'd upstream this too...

This revision is now accepted and ready to land.Thu, Nov 27, 10:44 PM

Do we still need to maintain contrib/jemalloc/FREEBSD-diffs?

In D53968#1233156, @markj wrote:

Do we still need to maintain contrib/jemalloc/FREEBSD-diffs?

No. If it's still there i should delete it.

Approved

In D53968#1233240, @imp wrote:

In D53968#1233156, @markj wrote:

Do we still need to maintain contrib/jemalloc/FREEBSD-diffs?

No. If it's still there i should delete it.

It's still there.

Closed by commit rG04d000a378b0: jemalloc: avoid clash with C23 unreachable() macro (authored by fuz). · Explain WhyFri, Nov 28, 3:58 PM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rG04d000a378b0: jemalloc: avoid clash with C23 unreachable() macro.

Revision Contents
Changeset List

Path

Size

contrib/

jemalloc/

include/

jemalloc/

internal/

util.h

3 lines

Diff 167216

View Options

contrib/jemalloc/include/jemalloc/internal/util.h

jemalloc: avoid clash with C23 unreachable() macroClosedPublicActions