uchar.h: add char8_t
ClosedPublic
Actions

Authored by fuz on Thu, Nov 27, 5:59 PM.

Details

Reviewers

ed
theraven
markj
imp

Commits

rGf0e541118c37: uchar.h: add char8_t

Summary

A type similar to char16 and char32_t, for compliance with C23.
The related type atomic_char8_t is added to stdatomic.h.
As char8_t is always unsigned char, I've skipped adding __char8_t.
This can be added, too, if desired.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 68891
Build 65774: arc lint + arc unit

Event Timeline

fuz created this revision.Thu, Nov 27, 5:59 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 27, 5:59 PM

fuz requested review of this revision.Thu, Nov 27, 5:59 PM

Harbormaster completed remote builds in B68891: Diff 167193.Thu, Nov 27, 5:59 PM

I'd be tempted to do separate commits, but it's not therrible if not. The change looks good to me.

This revision is now accepted and ready to land.Fri, Nov 28, 6:54 AM

Approved

theraven added inline comments.Fri, Nov 28, 2:34 PM

include/uchar.h
36	Isn't this missing `#define _CHAR8_T_DECLARED`?

fuz added inline comments.Fri, Nov 28, 2:56 PM

include/uchar.h
36	Indeed—I'll fix that on commit.

Closed by commit rGf0e541118c37: uchar.h: add char8_t (authored by fuz). · Explain WhyFri, Nov 28, 3:20 PM

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rGf0e541118c37: uchar.h: add char8_t.

fuz added a child revision: D54124: sys/_types.h: recognise char8_t as a builtin type in C++20.Mon, Dec 8, 12:38 PM

Revision Contents
Changeset List

Path

Size

include/

uchar.h

4 lines

sys/

stdatomic.h

6 lines

Diff 167193

View Options

include/uchar.h