Page MenuHomeFreeBSD
Differential D53793

sh: Fix job pointer invalidation with trapsasync
ClosedPublic
Actions

Authored by jilles on Nov 17 2025, 6:27 PM.
Tags
None
Referenced Files
F145187289: D53793.id166589.diff
Mon, Feb 16, 9:58 PM
F145174186: D53793.diff
Mon, Feb 16, 6:43 PM
Unknown Object (File)
Mon, Feb 2, 10:37 AM
Unknown Object (File)
Wed, Jan 28, 12:46 AM
Unknown Object (File)
Tue, Jan 27, 8:29 PM
Unknown Object (File)
Jan 3 2026, 5:00 PM
Unknown Object (File)
Dec 27 2025, 1:12 AM
Unknown Object (File)
Dec 22 2025, 8:02 PM
View All 25 Files
Subscribers
imp

Details

Reviewers
bdrewery
Commits
rGe45b89582fcb: sh: Fix job pointer invalidation with trapsasync
rG21d665d7dd9e: sh: Fix job pointer invalidation with trapsasync
rG5f95e0e9dcca: sh: Fix job pointer invalidation with trapsasync
rGf44ac8cc9c10: sh: Fix job pointer invalidation with trapsasync
Summary

Calling dotrap() can do almost anything, including reallocating the
jobtab array. Convert the job pointer to an index before calling
dotrap() and then restore a proper job pointer afterwards.

PR: 290330
Reported by: bdrewery

Test Plan

Install patched sh with new tests, cd /usr/tests/bin/sh && kyua test and reboot (all within a virtual machine).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
bin/
sh/
6 lines
tests/
execution/
1 line
9 lines

Diff 166800

View Options

bin/sh/jobs.c

Loading...
View Options

bin/sh/tests/execution/Makefile

Loading...
View Options

bin/sh/tests/execution/bg14.0

Loading...