Differential D53726

quot: Rewrite -n mode input parser
ClosedPublic
Actions

Authored by des on Nov 13 2025, 10:27 AM.

Tags

None

Referenced Files

	F151318854: D53726.id.diff
	Tue, Apr 7, 1:54 PM

	F151290317: D53726.id166443.diff
	Tue, Apr 7, 8:57 AM

	Unknown Object (File)
	Sun, Apr 5, 8:21 PM

	Unknown Object (File)
	Fri, Apr 3, 5:55 PM

	Unknown Object (File)
	Tue, Mar 17, 9:37 PM

	Unknown Object (File)
	Mar 6 2026, 4:26 PM

	Unknown Object (File)
	Mar 6 2026, 4:35 AM

	Unknown Object (File)
	Mar 5 2026, 6:32 AM

View All 41 Files

Subscribers

Details

Reviewers

Commits

rGa2630fec78b6: quot: Rewrite -n mode input parser
rG179fa1d81c73: quot: Rewrite -n mode input parser
rGd019d36707d3: quot: Rewrite -n mode input parser
rGfa272a527686: quot: Rewrite -n mode input parser

Summary

The existing parser was needlessly complicated and wildly inconsistent
in how it handled invalid input. Rewrite using getline() and treat
invalid input consistently: silently ignore lines that don't begin with
a number, and print a warning if the inode number is out of range.

PR: 290992
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68592
Build 65475: arc lint + arc unit

Event Timeline

des created this revision.Nov 13 2025, 10:27 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptNov 13 2025, 10:27 AM

des requested review of this revision.Nov 13 2025, 10:27 AM

Harbormaster completed remote builds in B68592: Diff 166346.Nov 13 2025, 10:27 AM

des added a child revision: D53727: quot: Improve manual page.Nov 13 2025, 10:28 AM

des edited the summary of this revision. (Show Details)Nov 13 2025, 10:29 AM

obrien accepted this revision.Nov 14 2025, 3:59 AM

This revision is now accepted and ready to land.Nov 14 2025, 3:59 AM

Closed by commit rGfa272a527686: quot: Rewrite -n mode input parser (authored by des). · Explain WhyNov 14 2025, 2:29 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGfa272a527686: quot: Rewrite -n mode input parser.

des added a commit: rGd019d36707d3: quot: Rewrite -n mode input parser.Nov 19 2025, 10:58 AM

des added a commit: rG179fa1d81c73: quot: Rewrite -n mode input parser.Nov 19 2025, 11:19 AM

des added a commit: rGa2630fec78b6: quot: Rewrite -n mode input parser.Nov 19 2025, 11:22 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

quot/

3 lines

47 lines

tests/

19 lines

Diff 166346

usr.sbin/quot/quot.8

Loading...

usr.sbin/quot/quot.c

Loading...

usr.sbin/quot/tests/quot_test.sh

Loading...