Differential D53726

quot: Rewrite -n mode input parser
ClosedPublic
Actions

Authored by des on Thu, Nov 13, 10:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 1, 5:21 AM

	Unknown Object (File)
	Fri, Nov 28, 11:16 AM

	Unknown Object (File)
	Tue, Nov 25, 2:36 PM

	Unknown Object (File)
	Tue, Nov 25, 1:20 PM

	Unknown Object (File)
	Sun, Nov 23, 2:58 PM

	Unknown Object (File)
	Sun, Nov 23, 7:12 AM

	Unknown Object (File)
	Sat, Nov 22, 1:35 PM

	Unknown Object (File)
	Thu, Nov 20, 9:55 AM

View All 23 Files

Subscribers

Details

Reviewers

Commits

rGa2630fec78b6: quot: Rewrite -n mode input parser
rG179fa1d81c73: quot: Rewrite -n mode input parser
rGd019d36707d3: quot: Rewrite -n mode input parser
rGfa272a527686: quot: Rewrite -n mode input parser

Summary

The existing parser was needlessly complicated and wildly inconsistent
in how it handled invalid input. Rewrite using getline() and treat
invalid input consistently: silently ignore lines that don't begin with
a number, and print a warning if the inode number is out of range.

PR: 290992
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Thu, Nov 13, 10:27 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Nov 13, 10:27 AM

des requested review of this revision.Thu, Nov 13, 10:27 AM

Harbormaster completed remote builds in B68592: Diff 166346.Thu, Nov 13, 10:27 AM

des added a child revision: D53727: quot: Improve manual page.Thu, Nov 13, 10:28 AM

des edited the summary of this revision. (Show Details)Thu, Nov 13, 10:29 AM

obrien accepted this revision.Fri, Nov 14, 3:59 AM

This revision is now accepted and ready to land.Fri, Nov 14, 3:59 AM

Closed by commit rGfa272a527686: quot: Rewrite -n mode input parser (authored by des). · Explain WhyFri, Nov 14, 2:29 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGfa272a527686: quot: Rewrite -n mode input parser.

des added a commit: rGd019d36707d3: quot: Rewrite -n mode input parser.Wed, Nov 19, 10:58 AM

des added a commit: rG179fa1d81c73: quot: Rewrite -n mode input parser.Wed, Nov 19, 11:19 AM

des added a commit: rGa2630fec78b6: quot: Rewrite -n mode input parser.Wed, Nov 19, 11:22 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

quot/

3 lines

47 lines

tests/

19 lines

Diff 166443

usr.sbin/quot/quot.8

Loading...

usr.sbin/quot/quot.c

Loading...

usr.sbin/quot/tests/quot_test.sh

Loading...