Page MenuHomeFreeBSD
Differential D53642

bsdinstall: use fat32 for ZFS
ClosedPublic
Actions

Authored by emaste on Sat, Nov 8, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 15, 3:18 PM
Unknown Object (File)
Fri, Nov 14, 7:42 AM
Unknown Object (File)
Fri, Nov 14, 7:41 AM
Unknown Object (File)
Fri, Nov 14, 5:05 AM
Unknown Object (File)
Fri, Nov 14, 5:05 AM
Unknown Object (File)
Fri, Nov 14, 5:05 AM
Unknown Object (File)
Fri, Nov 14, 5:05 AM
Unknown Object (File)
Fri, Nov 14, 5:05 AM
View All 23 Files
Subscribers
jrtc27
releng

Details

Reviewers
imp
Commits
rGc5977a934c6a: bsdinstall: Use fat32 EFI system partition for ZFS
rGad17166c57bb: bsdinstall: Use fat32 EFI system partition for ZFS
rG65e347d31544: bsdinstall: Use fat32 EFI system partition for ZFS
rG4109cdf0f817: bsdinstall: Use fat32 EFI system partition for ZFS
Summary

EFI implementations must support all of fat12, fat16, and fat32, but other operating systems typically use fat32 for the EFI system partition. The UFS install path also uses fat32. Follow suit in ZFS.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Sat, Nov 8, 3:23 PM
Herald added a subscriber: jrtc27. · View Herald TranscriptSat, Nov 8, 3:23 PM
emaste requested review of this revision.Sat, Nov 8, 3:23 PM
imp accepted this revision.Sat, Nov 8, 5:03 PM

I would, however, like to see this super ugly construct die in a fire. It's way way way over-engineered with little good effect. There's 4 layers of indirections for logging and that's 3 too many.

This revision is now accepted and ready to land.Sat, Nov 8, 5:03 PM
emaste updated this revision to Diff 166129.Mon, Nov 10, 2:14 PM

Use -c 1 consistent with the UFS config.

This revision now requires review to proceed.Mon, Nov 10, 2:14 PM
emaste updated this revision to Diff 166130.Mon, Nov 10, 2:15 PM

Upload correct diff

emaste added a comment.Mon, Nov 10, 6:53 PM

Fixes: 0b7472b3d8d2 ("Mount the EFI system partition (ESP) on newly-installed systems.")

Prior to that commit we newfs'd the ESP with newfs_msdos -F 32 -c 1 -L EFISYS "/dev/$esp" > /dev/null 2>&1

imp accepted this revision.Tue, Nov 11, 5:45 PM

I'm a little nervous about -c 1, but it should be adequate across a reasonable range of partition sizes.

This revision is now accepted and ready to land.Tue, Nov 11, 5:45 PM
Closed by commit rG4109cdf0f817: bsdinstall: Use fat32 EFI system partition for ZFS (authored by emaste). · Explain WhyTue, Nov 11, 6:18 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG4109cdf0f817: bsdinstall: Use fat32 EFI system partition for ZFS.
emaste added a commit: rG65e347d31544: bsdinstall: Use fat32 EFI system partition for ZFS.Wed, Nov 12, 1:25 PM
emaste added a commit: rGad17166c57bb: bsdinstall: Use fat32 EFI system partition for ZFS.Wed, Nov 12, 3:48 PM
cperciva added a commit: rGc5977a934c6a: bsdinstall: Use fat32 EFI system partition for ZFS.Wed, Nov 12, 6:46 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
2 lines

Diff 166129

View Options

usr.sbin/bsdinstall/scripts/zfsboot

Loading...