Page MenuHomeFreeBSD
Differential D53633

acpi: add counters for cumulative time spent in each sleep state.
ClosedPublic
Actions

Authored by adrian on Fri, Nov 7, 4:39 AM.
Tags
None
Referenced Files
F136848326: D53633.id.diff
Thu, Nov 20, 1:53 AM
F136848311: D53633.id166015.diff
Thu, Nov 20, 1:52 AM
F136848306: D53633.id166269.diff
Thu, Nov 20, 1:52 AM
F136847897: D53633.diff
Thu, Nov 20, 1:48 AM
Unknown Object (File)
Fri, Nov 14, 9:19 PM
Unknown Object (File)
Fri, Nov 14, 9:19 PM
Unknown Object (File)
Fri, Nov 14, 9:19 PM
Unknown Object (File)
Fri, Nov 14, 6:35 PM
View All 19 Files
Subscribers
gallatin
imp

Details

Reviewers
obiwac
imp
gallatin
adrian
Commits
rG53880f09fb1b: acpi: add counters for cumulative time spent in each sleep state.
Summary

Add this so it can be consumed/graphed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68473
Build 65356: arc lint + arc unit

Event Timeline

adrian created this revision.Fri, Nov 7, 4:39 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 7, 4:39 AM
Harbormaster completed remote builds in B68473: Diff 166015.Fri, Nov 7, 4:39 AM
adrian requested review of this revision.Fri, Nov 7, 4:39 AM
adrian added a reviewer: obiwac.Fri, Nov 7, 4:45 AM
imp accepted this revision.Fri, Nov 7, 4:53 AM

Seems legit. It's per cpu already so it should be this simple. Maybe check on the size of the cpu so it doesn't spill to a new cache line

This revision is now accepted and ready to land.Fri, Nov 7, 4:53 AM
adrian accepted this revision.Tue, Nov 11, 4:18 PM
adrian added a reviewer: gallatin.
adrian added a subscriber: gallatin.

Hi @gallatin would you mind helping me eyeball what the cacheline size / offset implications would be for extending the per-CPU ACPI stuff like this? Thanks!

gallatin accepted this revision.Tue, Nov 11, 4:44 PM
Closed by commit rG53880f09fb1b: acpi: add counters for cumulative time spent in each sleep state. (authored by adrian). · Explain WhyTue, Nov 11, 8:45 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG53880f09fb1b: acpi: add counters for cumulative time spent in each sleep state..

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
30 lines

Diff 166015

View Options

sys/dev/acpica/acpi_cpu.c

Loading...