Page MenuHomeFreeBSD
Differential D53224

quot: Make nusers unsigned
ClosedPublic
Actions

Authored by des on Oct 20 2025, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 17, 6:52 AM
Unknown Object (File)
Thu, Aug 13, 12:16 PM
Unknown Object (File)
Thu, Aug 13, 12:15 PM
Unknown Object (File)
Thu, Aug 13, 1:03 AM
Unknown Object (File)
Thu, Aug 13, 12:38 AM
Unknown Object (File)
Wed, Aug 12, 3:29 PM
Unknown Object (File)
Mon, Aug 10, 12:28 PM
Unknown Object (File)
Mon, Aug 10, 12:04 PM
View All Files
Subscribers
imp

Details

Reviewers
rlibby
Commits
rG201038a01ba8: quot: Make nusers unsigned
rG2427ae41b7cf: quot: Make nusers unsigned
rGfa347930f89d: quot: Make nusers unsigned
Summary

Fixes: 195b00ec45e5 ("quot: Clean up")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67945
Build 64828: arc lint + arc unit

Event Timeline

des created this revision.Oct 20 2025, 5:55 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2025, 5:55 PM
des requested review of this revision.Oct 20 2025, 5:55 PM
Harbormaster completed remote builds in B67945: Diff 164641.Oct 20 2025, 5:55 PM
rlibby accepted this revision.Oct 20 2025, 7:21 PM

Thanks for the follow up.

usr.sbin/quot/quot.c
194

This is good but consider if you prefer a more conventional for (usr = users, i = 0; i < nusers; usr++, i++) or similar here. Similar question for other loop counters.

212

I see that there's more of a reason to count backward here.

374

Did you want to give n and this line the same treatment?

This revision is now accepted and ready to land.Oct 20 2025, 7:21 PM
des added inline comments.Oct 20 2025, 9:41 PM
usr.sbin/quot/quot.c
194

See D53130

Closed by commit rGfa347930f89d: quot: Make nusers unsigned (authored by des). · Explain WhyOct 20 2025, 9:42 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGfa347930f89d: quot: Make nusers unsigned.
des added a commit: rG2427ae41b7cf: quot: Make nusers unsigned.
cperciva added a commit: rG201038a01ba8: quot: Make nusers unsigned.Oct 30 2025, 11:53 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
quot/
27 lines

Diff 164641

View Options

usr.sbin/quot/quot.c

Loading...