nullfs: add nounixbypass mount option
ClosedPublic
Actions

Authored by kib on Wed, Oct 8, 4:10 PM.

Details

Reviewers

Commits

rG033587a985a4: mount_nullfs.8: document unixbypass and nounixbypass
rG6fa205a6233f: nullfs: add nounixbypass mount option
rG8e6f6a5fbde7: nullfs_mount: use symbols instead of string literals for cache mount options
rG419f2fe6b70b: nullfs: add a helper for testing if vnode belongs to a nullfs mount
rG035f1971ade4: fs/nullfs/null.h: put first definition after headers include

Summary

nullfs: add nounp_bypass mount option

The option, when set, disables bypassing the unix socket vnode down
to the lower mp, effectively preventing connection to nullfs unix
socket from being acceptable from the lower mp (and vice versa).

This is done by providing a vop vector that stops bypass for unp-related
VOPs.  I believe that VFS_VOP_VECTOR_REGISTER() does the right thing
there regardless of the order of initialization.


nullfs_mount: use symbols instead of string literals for cache mount options


nullfs: add helper testing for vnode belonging to nullfs mount


fs/nullfs/null.h: put first definition after headers include

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Wed, Oct 8, 4:10 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Oct 8, 4:10 PM

kib requested review of this revision.Wed, Oct 8, 4:10 PM

This should be documented in mount_nullfs.8. The implementation looks ok to me.

The name sounds a bit strange to me. The mount_nullfs terminology explains what "bypass" means, but it's still a bit unclear IMO. What do you think about unix_private, nounix_private?

In D52983#1210802, @markj wrote:

This should be documented in mount_nullfs.8. The implementation looks ok to me.

I will after the patch is finalized.

The name sounds a bit strange to me. The mount_nullfs terminology explains what "bypass" means, but it's still a bit unclear IMO. What do you think about unix_private, nounix_private?

For me, 'private' is worse. What exactly is the scope where the socket becomes private? People would think about jails or whatever namespace restriction they intend, but not the pass from upper to lower.
I can rename user-visible option to unixbypass e.g.

In D52983#1210842, @kib wrote:

In D52983#1210802, @markj wrote:

This should be documented in mount_nullfs.8. The implementation looks ok to me.

I will after the patch is finalized.

The name sounds a bit strange to me. The mount_nullfs terminology explains what "bypass" means, but it's still a bit unclear IMO. What do you think about unix_private, nounix_private?

For me, 'private' is worse. What exactly is the scope where the socket becomes private? People would think about jails or whatever namespace restriction they intend, but not the pass from upper to lower.
I can rename user-visible option to unixbypass e.g.

unixbypass or unix_bypass is ok with me.

Rename the option to 'unixbypass'.
Add documentation.

Herald added a subscriber: ziaee. · View Herald TranscriptThu, Oct 9, 8:56 PM

markj added inline comments.Thu, Oct 9, 10:10 PM

sbin/mount_nullfs/mount_nullfs.8
102 ↗	(On Diff #163872)
118 ↗	(On Diff #163872)
119 ↗	(On Diff #163872)
122 ↗	(On Diff #163872)
124 ↗	(On Diff #163872)
sys/fs/nullfs/null.h
42	Rename the flag and VOP vector as well, to keep things consistent?