Page MenuHomeFreeBSD
Differential D52896

ice.4: Avoid first person language
ClosedPublic
Actions

Authored by brd on Fri, Oct 3, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 3:29 PM
Unknown Object (File)
Sun, Oct 5, 5:06 AM
Unknown Object (File)
Sun, Oct 5, 4:33 AM
Unknown Object (File)
Sun, Oct 5, 3:30 AM
Unknown Object (File)
Sun, Oct 5, 3:24 AM
Unknown Object (File)
Sat, Oct 4, 10:14 AM
Unknown Object (File)
Sat, Oct 4, 7:57 AM
Unknown Object (File)
Sat, Oct 4, 2:27 AM
View All 13 Files
Subscribers
imp
ziaee

Details

Reviewers
bcr
ziaee
Commits
rG85531add2844: ice.4: Avoid first person language

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67535
Build 64418: arc lint + arc unit

Event Timeline

brd created this revision.Fri, Oct 3, 10:03 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Oct 3, 10:03 PM
brd requested review of this revision.Fri, Oct 3, 10:03 PM
Harbormaster completed remote builds in B67534: Diff 163499.Fri, Oct 3, 10:03 PM
brd updated this revision to Diff 163500.Fri, Oct 3, 10:07 PM

Bump Dd

Harbormaster completed remote builds in B67535: Diff 163500.Fri, Oct 3, 10:07 PM
ziaee accepted this revision.Sat, Oct 4, 3:06 AM
ziaee added inline comments.
share/man/man4/ice.4
43

Better is to avoid prose here at all according to the mdoc maintainer and also the lightning talk I gave at BSDcan. https://youtu.be/RthIOXpwwsM

418

I think this should actually be "If the
.Va allow_no_fec_modules_in_auto
sysctl is enabled...".

Sysctls are Va according to style.mdoc, because then you can apropos Va=here.is.the.sysctl.

764
This revision is now accepted and ready to land.Sat, Oct 4, 3:06 AM
brd updated this revision to Diff 163548.Sat, Oct 4, 5:57 PM
brd marked 2 inline comments as done.

Address feedback from ziaee

This revision now requires review to proceed.Sat, Oct 4, 5:57 PM
Harbormaster completed remote builds in B67550: Diff 163548.Sat, Oct 4, 5:57 PM
brd added a comment.Sat, Oct 4, 5:58 PM

@ziaee Thanks for taking the time to review!

share/man/man4/ice.4
43

I am sorry, I am not sure what you mean here? Most driver man pages have this exact text.

brd marked an inline comment as not done.Sat, Oct 4, 5:58 PM
ziaee accepted this revision.Sat, Oct 4, 8:29 PM

Please commit this so I can rewrite the synopsis. Thanks

This revision is now accepted and ready to land.Sat, Oct 4, 8:29 PM
Closed by commit rG85531add2844: ice.4: Avoid first person language (authored by brd). · Explain WhySat, Oct 4, 8:46 PM
This revision was automatically updated to reflect the committed changes.
brd added a commit: rG85531add2844: ice.4: Avoid first person language.
brd added a comment.Sat, Oct 4, 8:48 PM

Done, thanks! Probably should look at all the driver man pages if that is the case.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
92 lines

Diff 163500

View Options

share/man/man4/ice.4

Loading...