Paths

Table of Contentst

Differential D6372

generic_timer Allow code to be compiled in even if device isn't present
ClosedPublic
Actions

Authored by manu on May 14 2016, 2:21 PM.

Details

Reviewers

andrew

Group Reviewers

ARM

Commits

rS299851: Allow arm generic_timer code to be included even if not present in the

Summary

The generic_timer code assume that the device is present, this allow code to be compiled in even if it's not.

Test Plan

Tested on A20 (generic timer) and A10 (no generic timer)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3745
Build 3788: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 16335.May 14 2016, 2:21 PM

manu retitled this revision from to generic_timer Allow code to be compiled in even if device isn't present.

manu updated this object.

manu edited the test plan for this revision. (Show Details)

manu added a reviewer: ARM.

manu set the repository for this revision to rS FreeBSD src repository - subversion.

manu added a project: ARM.

Herald added subscribers: andrew, imp. · View Herald TranscriptMay 14 2016, 2:21 PM

andrew added inline comments.May 14 2016, 3:14 PM

sys/arm/arm/generic_timer.c
217	`!= NULL`

Fix style(9)

manu marked an inline comment as done.May 14 2016, 6:27 PM

andrew accepted this revision.May 14 2016, 8:35 PM

andrew added a reviewer: andrew.

This revision is now accepted and ready to land.May 14 2016, 8:35 PM

Closed by commit rS299851: Allow arm generic_timer code to be included even if not present in the (authored by manu). · Explain WhyMay 15 2016, 1:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

generic_timer.c

3 lines

Diff 16335

View Options

sys/arm/arm/generic_timer.c

generic_timer Allow code to be compiled in even if device isn't presentClosedPublicActions