Page MenuHomeFreeBSD
Differential D52833

bsd.cpu.mk: Fix whitespace appending to MACHINE_ABI
ClosedPublic
Actions

Authored by brooks on Oct 1 2025, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 30, 8:24 PM
Unknown Object (File)
Jan 2 2026, 2:18 PM
Unknown Object (File)
Dec 26 2025, 5:45 AM
Unknown Object (File)
Dec 19 2025, 11:08 PM
Unknown Object (File)
Dec 19 2025, 9:41 AM
Unknown Object (File)
Dec 10 2025, 11:10 AM
Unknown Object (File)
Nov 23 2025, 5:11 PM
Unknown Object (File)
Nov 20 2025, 11:47 AM
View All 28 Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
imp
Group Reviewers
cheri
Commits
rG90d2aedbb964: bsd.cpu.mk: Fix whitespace appending to MACHINE_ABI
Summary

Effort: CHERI upstreaming
Sponsored by: Innovate UK
Fixes: 426fc376afaf ("bsd.cpu.mk: Introduce MACHINE_ABI")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67458
Build 64341: arc lint + arc unit

Event Timeline

brooks created this revision.Oct 1 2025, 3:55 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptOct 1 2025, 3:55 PM
brooks requested review of this revision.Oct 1 2025, 3:55 PM
Harbormaster completed remote builds in B67458: Diff 163254.Oct 1 2025, 3:55 PM
imp accepted this revision.Oct 1 2025, 4:06 PM

Fun. Commit message could be better at explaining why this happens with the old code

This revision is now accepted and ready to land.Oct 1 2025, 4:06 PM
brooks added a comment.Oct 1 2025, 4:23 PM
In D52833#1207103, @imp wrote:

Fun. Commit message could be better at explaining why this happens with the old code

There's no functional change. It's just that I copied and pasted without tabs.

imp added a comment.Oct 1 2025, 8:48 PM
In D52833#1207111, @brooks wrote:
In D52833#1207103, @imp wrote:

Fun. Commit message could be better at explaining why this happens with the old code

There's no functional change. It's just that I copied and pasted without tabs.

Ah! I thought it has other implications...

Closed by commit rG90d2aedbb964: bsd.cpu.mk: Fix whitespace appending to MACHINE_ABI (authored by brooks). · Explain WhyOct 2 2025, 9:29 AM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG90d2aedbb964: bsd.cpu.mk: Fix whitespace appending to MACHINE_ABI.

Revision Contents
Changeset List

PathSize
share/
mk/
12 lines

Diff 163254

View Options

share/mk/bsd.cpu.mk

Loading...