Fix "need root" logic for PORT_DBDIR.
ClosedPublic
Actions

Authored by jonathan on May 13 2016, 4:11 PM.

Details

Reviewers

bapt
bdrewery
mat

Group Reviewers

portmgr

Commits

rP415154: Fix "need root" logic for PORT_DBDIR.

Summary

When PORT_DBDIR is set to a user directory, we shouldn't need su to
manipulate options. This also shouldn't depend on INSTALL_BY_USER, as
building != installing.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 3722
Build 3765: arc lint + arc unit

Event Timeline

jonathan updated this revision to Diff 16295.May 13 2016, 4:11 PM

jonathan retitled this revision from to Fix "need root" logic for PORT_DBDIR..

jonathan updated this object.

jonathan edited the test plan for this revision. (Show Details)

jonathan added reviewers: bapt, bdrewery, mat.

Herald added a reviewer: portmgr. · View Herald TranscriptMay 13 2016, 4:11 PM

bapt accepted this revision.May 13 2016, 7:53 PM

bapt edited edge metadata.

This revision is now accepted and ready to land.May 13 2016, 7:53 PM

Closed by commit rP415154: Fix "need root" logic for PORT_DBDIR. (authored by jonathan). · Explain WhyMay 13 2016, 8:53 PM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.May 17 2016, 2:45 PM

head/Mk/bsd.port.mk
5249–5250 ↗	(On Diff #16313)	It would have been nice to not change the sh style, in the ports/Mk/* we write: if [ foo ]; then not if [ foo ]; then

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

6 lines

Diff 16295

View Options

Fix "need root" logic for PORT_DBDIR.ClosedPublicActions