vfs: fix vfs_bio_bzero_buf() for PAGE_SIZE > block size
Needs ReviewPublic
Actions

Authored by chs on Sep 25 2025, 6:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 7, 8:10 PM

	Unknown Object (File)
	Tue, Apr 7, 4:38 AM

	Unknown Object (File)
	Sun, Apr 5, 6:28 PM

	Unknown Object (File)
	Tue, Mar 17, 4:58 AM

	Unknown Object (File)
	Tue, Mar 17, 3:22 AM

	Unknown Object (File)
	Sun, Mar 15, 11:05 AM

	Unknown Object (File)
	Feb 8 2026, 3:45 PM

	Unknown Object (File)
	Feb 2 2026, 6:06 AM

View All 36 Files

Subscribers

olce

Details

Reviewers

imp
kib
markj

Summary

The "base" argument to vfs_bio_bzero_buf() is the offset within
the buf, but when the page size is larger than the buf size
then the buf might not start at the beginning of its page.
Add the offset of the buf within the page to account for this.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67334
Build 64217: arc lint + arc unit

Event Timeline

chs created this revision.Sep 25 2025, 6:27 PM

Herald added a subscriber: olce. · View Herald TranscriptSep 25 2025, 6:27 PM

chs requested review of this revision.Sep 25 2025, 6:27 PM

Harbormaster completed remote builds in B67334: Diff 162841.Sep 25 2025, 6:27 PM

Consider an example where base == PAGE_SIZE / 2, b_offset == PAGE_SIZE / 2. In this case pgoff == PAGE_SIZE, n = 0, and each iteration of the loop seems to do nothing.

And generally pgoff might be larger than PAGE_SIZE, in which case n become negative.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_bio.c

10 lines

Diff 162841

View Options

vfs: fix vfs_bio_bzero_buf() for PAGE_SIZE > block sizeNeeds ReviewPublicActions