Page MenuHomeFreeBSD

Fix pci_host_generic IOPORT
ClosedPublic

Authored by bz on May 12 2016, 6:18 PM.
Tags
None
Referenced Files
F102229501: D6337.id16281.diff
Sat, Nov 9, 6:04 AM
Unknown Object (File)
Fri, Nov 8, 4:57 AM
Unknown Object (File)
Tue, Nov 5, 9:57 AM
Unknown Object (File)
Mon, Oct 28, 10:27 AM
Unknown Object (File)
Tue, Oct 22, 9:56 AM
Unknown Object (File)
Oct 3 2024, 10:11 AM
Unknown Object (File)
Oct 1 2024, 4:33 PM
Unknown Object (File)
Sep 17 2024, 11:09 PM
Subscribers

Details

Summary

When using IOPORT with pci_host_generic we are missing
setting the rman_end() which leads to end being before
start and thus a signed extended very large number of
size later on, which kva_alloc() will fail upon and we
will panic. Add the missing call.

Debugged with: andrew
Reviewed by:
Sponsored by: DARPA/AFRL
Found: while using virtio with gem5

Test Plan

Botting gem5 x86, armv7, arm64 with virtio/pci disks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz retitled this revision from to Fix pci_host_generic IOPORT.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: andrew, br.
bz set the repository for this revision to rS FreeBSD src repository - subversion.
andrew edited edge metadata.

We might also need to update the virtual address, but that doesn't seem to have been an issue so far.

This revision is now accepted and ready to land.May 12 2016, 8:26 PM
br edited edge metadata.
This revision was automatically updated to reflect the committed changes.