dtraceall: Enable kinst for aarch64 and riscv as well
ClosedPublic
Actions

Authored by christos on Tue, Sep 16, 1:59 PM.

Details

Reviewers

markj
gnn

Commits

rGa8e11e3c6208: dtraceall: Enable kinst for aarch64 and riscv as well
rGabdd81f0a5d5: dtraceall: Enable kinst for aarch64 and riscv as well
rG67f3c0d6a575: dtraceall: Enable kinst for aarch64 and riscv as well

Summary

aarch64 and riscv are supported since 2023 so it should be safe to
enable it by default.

MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Tue, Sep 16, 1:59 PM

Herald added a reviewer: gnn. · View Herald TranscriptTue, Sep 16, 1:59 PM

Herald added a subscriber: imp. · View Herald Transcript

christos requested review of this revision.Tue, Sep 16, 1:59 PM

Harbormaster completed remote builds in B67081: Diff 162152.Tue, Sep 16, 1:59 PM

markj accepted this revision.Tue, Sep 16, 3:26 PM

This revision is now accepted and ready to land.Tue, Sep 16, 3:26 PM

MFC after: 2 days

Why do you use such short MFC timeouts for non-urgent things? It takes time for other folks to update and test changes, which is the purpose of having the MFC period.

In D52575#1200461, @markj wrote:

MFC after: 2 days

Why do you use such short MFC timeouts for non-urgent things? It takes time for other folks to update and test changes, which is the purpose of having the MFC period.

In this case because I thought the change is simple enough. I can bump it to 1-2 weeks if you want.

In D52575#1200462, @christos wrote:

In D52575#1200461, @markj wrote:

MFC after: 2 days

Why do you use such short MFC timeouts for non-urgent things? It takes time for other folks to update and test changes, which is the purpose of having the MFC period.

In this case because I thought the change is simple enough. I can bump it to 1-2 weeks if you want.

Simple changes can and do break in surprising ways. In general I think an MFC period of less than one week should be avoided except for emergencies.

In D52575#1200464, @markj wrote:

In D52575#1200462, @christos wrote:

In D52575#1200461, @markj wrote:

MFC after: 2 days

Why do you use such short MFC timeouts for non-urgent things? It takes time for other folks to update and test changes, which is the purpose of having the MFC period.

In this case because I thought the change is simple enough. I can bump it to 1-2 weeks if you want.

Simple changes can and do break in surprising ways. In general I think an MFC period of less than one week should be avoided except for emergencies.