Deorbit ALLOW_SHARED_TEXTREL
ClosedPublic
Actions

Authored by emaste on May 11 2016, 4:59 PM.

Details

Reviewers

Commits

Summary

We want to avoid .text relocations in shared objects. libcrypto was the only consumer and it is now fixed, so remove the now-unused support for disabling the linker warning.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 16209.May 11 2016, 4:59 PM

emaste retitled this revision from to Deorbit ALLOW_SHARED_TEXTREL.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: kib.

emaste added a subscriber: jkim.

Herald added a subscriber: bdrewery. · View Herald TranscriptMay 11 2016, 4:59 PM

This might make harder future imports of buggy libraries in future. OTOH, the LD_FATAL_WARNING knob provides the same functionality still.

This revision is now accepted and ready to land.May 11 2016, 5:38 PM

This might make harder future imports of buggy libraries in future. OTOH, the LD_FATAL_WARNING knob provides the same functionality still.

Yeah, my hope is that this might encourage a future importer of a buggy library to fix it first, and if not at least the ld warning will come out in the log.

Closed by commit rS299474: Deorbit ALLOW_SHARED_TEXTREL (authored by emaste). · Explain WhyMay 11 2016, 5:55 PM

This revision was automatically updated to reflect the committed changes.