Details
- Reviewers
ivy junchoon_dec.sakura.ne.jp dumbbell emaste - Group Reviewers
x11 - Commits
- R11:89a7952ac8b6: drm: Clean up comments
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 67055 Build 63938: arc lint + arc unit
Event Timeline
fine by me, except please ensure we refer to Rocky Linux(tm) by its official name.
| graphics/linux-c7-libdrm/Makefile | ||
|---|---|---|
| 7 | this and the rl9 comment should possibly include the string "Direct Rendering Manager" and possibly the word "GPU" (but not "drivers"), just for consistency, but i don't feel particularly strong about this. | |
| graphics/linux-rl9-libdrm/Makefile | ||
| 7 | the OS is called "Rocky Linux", not just "Rocky". | |
| graphics/linux-c7-libdrm/Makefile | ||
|---|---|---|
| 7 | +1 for it. Shortened term GPU (Graphics Processing Unit) wouldn't be confusing, but OTOH, shortened term DRM can be confused with "Digital Rights Management". | |
It would be better unifying the terms to "Direct Rendering Manager" instead of "DRM" and "Direct Rendering interface".
I have no intention to reject (if so, as I'm assigned as reviewer, I would have rejected).
Just thought it would be clearer.
If you've used the term "Direct Rendering interface" for linux-*-libdrm to indicate these are interface libraries,
graphics/libdrm has "COMMENT= Direct Rendering Manager library and headers"
https://cgit.freebsd.org/ports/tree/graphics/libdrm/Makefile#n8
The only thing I wondered to reject or not is "Rocky" and "Rocky Linux" case as ivy commented. Anything else looks better than before for me.