devel/stc: [NEW PORT] Modern, user-friendly, generic, type-safe and fast C99 library
ClosedPublic
Actions

Authored by alven on Sun, Sep 14, 9:45 AM.

Details

Reviewers

db
yuri

Commits

R11:050e562c9dd9: devel/stc: [NEW PORT] Modern, user-friendly, generic, type-safe and fast C99…

Summary

STC is a mature, comprehensive, general purpose container and
algorithm library for C99/C11. It has excellent ergonomics and
requires virtually no boilerplate code. The library adds many missing
features to C, like common data containers, algorithms, and
abstractions found in contemporary system languages like Zig, Rust,
and C++. Containers and algorithms are templated or generic, which
allows for a fully typesafe, compact, and high performance
implementation.

WWW: https://github.com/stclib/STC/

Test Plan

For every {amd64, i386} × {14.3, 13.5}:

Successful poudriere testport

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 67008
Build 63891: arc lint + arc unit

Event Timeline

alven requested review of this revision.Sun, Sep 14, 9:45 AM

alven created this revision.

Harbormaster completed remote builds in B67007: Diff 161993.Sun, Sep 14, 9:45 AM

Update maintainer email

Harbormaster completed remote builds in B67008: Diff 161994.Sun, Sep 14, 9:51 AM

yuri added inline comments.Thu, Sep 18, 9:42 AM

devel/STC/Makefile
1	Please change to lowercase 'stc'. Same for the directory name. You'll get a lot of complaints with capital letters in the port names/directory names.
devel/STC/pkg-descr
54	I think that pkg-descr is too long. portlint has 24 line limit hard-coded.
devel/STC/pkg-plist
183	Please consider using PORTDOCS= * and PORTEXAMPLES= * in Makefile to shorten pkg-list. There's not much value in explicitly listing docs/example files, IMO.

alven added inline comments.Fri, Sep 19, 12:01 PM

devel/STC/Makefile
1	FATAL: Makefile: The package base name "stc" is already in use by the "net/stc" port. Choose another PORTNAME or use a PKGNAMEPREFIX or PKGNAMESUFFIX. How to better overcome this? Given Repology have this program named stc, but in Ports tree this name is already taken [0]... [0] https://repology.org/project/stc/versions

alven retitled this revision from devel/STC: [NEW PORT] Modern, user friendly, generic, type-safe and fast C99 container library to devel/STC: [NEW PORT] Modern, user-friendly, generic, type-safe and fast C99 library.Fri, Sep 19, 12:11 PM

Address review issues

Harbormaster completed remote builds in B67158: Diff 162406.Fri, Sep 19, 12:12 PM

alven retitled this revision from devel/STC: [NEW PORT] Modern, user-friendly, generic, type-safe and fast C99 library to devel/stc: [NEW PORT] Modern, user-friendly, generic, type-safe and fast C99 library.Fri, Sep 19, 12:14 PM

Approved.

Thanks,
Yuri

This revision is now accepted and ready to land.Sat, Sep 20, 8:02 AM

Thank you for the review.

I also need your advice: how to better overcome name collision with net/stc?
Uppercase was an attempt to do exactly this, but you may have better variant?

In D52520#1202389, @alven wrote:

Thank you for the review.

I also need your advice: how to better overcome name collision with net/stc?
Uppercase was an attempt to do exactly this, but you may have better variant?

Hi Alven,

In order to overcome name collision you need to add PKGNAMESUFFIX.
For example,