Page MenuHomeFreeBSD
Differential D52443

sys/sysctl.h: Make self-contained
Changes PlannedPublic
Actions

Authored by obiwac on Sep 9 2025, 12:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 8, 2:01 PM
Unknown Object (File)
Thu, Aug 6, 11:57 PM
Unknown Object (File)
Wed, Aug 5, 4:54 AM
Unknown Object (File)
Tue, Aug 4, 2:19 AM
Unknown Object (File)
Thu, Jul 30, 1:55 PM
Unknown Object (File)
Sun, Jul 26, 4:57 PM
Unknown Object (File)
Thu, Jul 23, 4:54 PM
Unknown Object (File)
Thu, Jul 23, 4:42 PM
View All 59 Files
Subscribers
imp
ziaee

Details

Reviewers
markj

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66918
Build 63801: arc lint + arc unit

Event Timeline

obiwac created this revision.Sep 9 2025, 12:09 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSep 9 2025, 12:09 PM
obiwac requested review of this revision.Sep 9 2025, 12:09 PM
Harbormaster completed remote builds in B66918: Diff 161780.Sep 9 2025, 12:09 PM
obiwac planned changes to this revision.Sep 9 2025, 12:09 PM
obiwac added a child revision: D52036: sys/power: Generic sleep types.

Actually this would need sys/types.h to be included because sysctl.h makes use of u_int and intmax_t. Is it okay to include this?

markj added a comment.Sep 9 2025, 12:19 PM
In D52443#1197695, @obiwac wrote:

Actually this would need sys/types.h to be included because sysctl.h makes use of u_int and intmax_t. Is it okay to include this?

Ah, yeah. I think that's ok. Let's include types.h in the _KERNEL block and leave the !_KERNEL block alone then.

imp added inline comments.Sep 9 2025, 8:58 PM
sys/sys/sysctl.h
44

why do wer need this?

markj added inline comments.Sep 9 2025, 9:18 PM
sys/sys/sysctl.h
44

Presumably we don't, it's only needed in the !_KERNEL case for __BEGIN_DECLS.

obiwac removed a child revision: D52036: sys/power: Generic sleep types.Sep 10 2025, 10:47 AM
obiwac mentioned this in D52036: sys/power: Generic sleep types.Sep 10 2025, 11:09 AM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
3 lines
sys/
sys/
14 lines

Diff 161780

View Options

share/man/man9/sysctl.9

Loading...
View Options

sys/sys/sysctl.h

Loading...