Details
- Reviewers
pouria hayzam_gmail.com
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 66882 Build 63765: arc lint + arc unit
Event Timeline
Hi, here is an improved version of your patch file: https://people.freebsd.org/~acm/ports/sylve.diff
Based on the patch provided by acm@, I removed the -r flag from daemon(8) and everything related to it. The reason is that, for example, if sylve fails for any reason, daemon(8) keeps restarting it over and over again, filling up /var/log/daemon.log. I think it's better to let sylve fail and let the user see what happened.
@acm thanks your patch handles the web bits already? awesome :-) I'd suggested to @hayzam_gmail.com that he could generate those
directly as part of his own release process.
| sysutils/sylve/files/sylve.in | ||
|---|---|---|
| 11–13 | Set the real default value here please | |
| sysutils/sylve/files/patch-config.example.json | ||
|---|---|---|
| 7 | The correct json key here is "dataPath", there are some more options in, we might need to update this file too as there are things that changed in config.example.json | |
| sysutils/sylve/files/pkg-message.in | ||
| 26 | I think we can get rid of these (_enable) lines, let Sylve manage the life cycle of these services on its own (if the user does enable them at the initialization step), as they might depend on things like bridges created by Sylve | |