Paths

Table of Contentst

Differential D52067

LinuxKPI: pci: implement pcim_iomap()
ClosedPublic
Actions

Authored by bz on Thu, Aug 21, 8:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 12, 7:41 AM

	Unknown Object (File)
	Sat, Sep 6, 12:05 PM

	Unknown Object (File)
	Sat, Sep 6, 12:09 AM

	Unknown Object (File)
	Tue, Sep 2, 1:14 PM

	Unknown Object (File)
	Tue, Aug 26, 9:57 AM

	Unknown Object (File)
	Mon, Aug 25, 1:22 PM

	Unknown Object (File)
	Mon, Aug 25, 1:01 PM

	Unknown Object (File)
	Mon, Aug 25, 9:37 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG2f9064a5d2b5: LinuxKPI: pci: implement pcim_iomap()

Summary

Like pci_iomap() add the devres version pcim_iomap() using the former
to get the resource.

Add a helper function to validate that the bar is within a valid range
and sprinkle that check also to other related functions.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 66803
Build 63686: arc lint + arc unit

Event Timeline

bz created this revision.Thu, Aug 21, 8:58 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptThu, Aug 21, 8:58 AM

bz requested review of this revision.Thu, Aug 21, 8:58 AM

Harbormaster completed remote builds in B66405: Diff 160721.Thu, Aug 21, 8:58 AM

dumbbell added a subscriber: dumbbell.Wed, Sep 3, 8:20 PM

dumbbell added inline comments.

sys/compat/linuxkpi/common/src/linux_pci.c
867–868	Perhaps we could put the setting of both tables in a static function to not duplicate code? The same logic is already present in `linuxkpi_pcim_iomap_regions()`. What do you think?

Factor out setting table into its own function.

Harbormaster completed remote builds in B66803: Diff 161469.Wed, Sep 3, 10:32 PM

bz marked an inline comment as done.Wed, Sep 3, 10:32 PM

dumbbell accepted this revision.Thu, Sep 4, 4:13 PM

This revision is now accepted and ready to land.Thu, Sep 4, 4:13 PM

bz added inline comments.Fri, Sep 5, 8:12 PM

sys/compat/linuxkpi/common/src/linux_pci.c
148	static

Closed by commit rG2f9064a5d2b5: LinuxKPI: pci: implement pcim_iomap() (authored by bz). · Explain WhyFri, Sep 5, 11:29 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG2f9064a5d2b5: LinuxKPI: pci: implement pcim_iomap().

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

src/

58 lines

Diff 161469

sys/compat/linuxkpi/common/include/linux/pci.h

Loading...

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...