Page MenuHomeFreeBSD
Differential D52312

fwget: pci: video amd: correct glob matching entries
ClosedPublic
Actions

Authored by bz on Sun, Aug 31, 7:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 6, 5:42 AM
Unknown Object (File)
Fri, Sep 5, 4:29 PM
Unknown Object (File)
Thu, Sep 4, 7:34 AM
Unknown Object (File)
Tue, Sep 2, 7:49 PM
Unknown Object (File)
Tue, Sep 2, 6:55 PM
Unknown Object (File)
Tue, Sep 2, 5:26 PM
Unknown Object (File)
Tue, Sep 2, 4:07 PM
Unknown Object (File)
Tue, Sep 2, 8:12 AM
View All 12 Files
Subscribers
imp

Details

Reviewers
manu
dumbbell
imp
Group Reviewers
x11
Commits
rG1d1265875593: fwget: pci: video amd: correct glob matching entries
Summary
  • one duplcate entry: 0x664*|0x664*) -> 0x664*|0x665*)
  • one unneeded glob: 0x98e4*) -> 0x98e4)
  • 0x15e7|0x1636|0x1638|0x164c) half of these are green-sardine; split

XXX do we need the renoir for them?

  • a missing entry for skillfish2 : + 0x143f

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Sun, Aug 31, 7:07 PM
bz created this revision.
Harbormaster completed remote builds in B66725: Diff 161303.Sun, Aug 31, 7:07 PM
imp accepted this revision as: imp.Sun, Aug 31, 7:34 PM

Don't like the globbing, but I understand that's being worked on in a replacement, so this is good to go.

This revision is now accepted and ready to land.Sun, Aug 31, 7:34 PM
bz added inline comments.Sun, Aug 31, 7:54 PM
usr.sbin/fwget/pci/pci_video_amd
115

I'll wait for feedback from @manu or @dumbbell on this one.

manu requested changes to this revision.Mon, Sep 1, 5:58 AM
manu added inline comments.
usr.sbin/fwget/pci/pci_video_amd
115

It's hard to know as there is no explicit list in the code, I'd rather not change this and only change if a user report that some pci id also needs the green sardine firmware. They're all taggued as renoir in the code (https://github.com/freebsd/drm-kmod/blob/master/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c#L2056) but later the code can load green sardine apu code based on some other stuff.

This revision now requires changes to proceed.Mon, Sep 1, 5:58 AM
bz added inline comments.Mon, Sep 1, 7:23 AM
usr.sbin/fwget/pci/pci_video_amd
115

True but like for Picasso above and shellyfish2 below (in here and there), there's a rewrite based on the device IDs and it seems the Picasso and shellyfish2 ones were taken into account but the green-sardine ones not? https://github.com/freebsd/drm-kmod/blob/master/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c#L1801

manu accepted this revision.Mon, Sep 1, 7:28 AM
manu added inline comments.
usr.sbin/fwget/pci/pci_video_amd
115

Ok right, then for those two we likely need both packages so you can remove the comment.

This revision is now accepted and ready to land.Mon, Sep 1, 7:28 AM
bz marked 2 inline comments as done.Mon, Sep 1, 7:35 AM
bz added inline comments.
usr.sbin/fwget/pci/pci_video_amd
115

Thanks, will do before commit. I have to admit I thought wireless driver firmware is a mess to get right but after having looked into video over the weekend, that is no better. :(

Closed by commit rG1d1265875593: fwget: pci: video amd: correct glob matching entries (authored by bz). · Explain WhyMon, Sep 1, 7:43 AM
This revision was automatically updated to reflect the committed changes.
bz marked an inline comment as done.
bz added a commit: rG1d1265875593: fwget: pci: video amd: correct glob matching entries.
manu added inline comments.Mon, Sep 1, 7:46 AM
usr.sbin/fwget/pci/pci_video_amd
115

Intel is ok and older amd too, but newer ones are a mess yes :)

Revision Contents
Changeset List

PathSize
usr.sbin/
fwget/
pci/
11 lines

Diff 161315

View Options

usr.sbin/fwget/pci/pci_video_amd

Loading...