Page MenuHomeFreeBSD
Differential D718

Remove dependency on gcc
ClosedPublic
Actions

Authored by sbruno on Sep 3 2014, 5:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 9:22 AM
Unknown Object (File)
Feb 3 2024, 8:26 AM
Unknown Object (File)
Jan 18 2024, 1:28 PM
Unknown Object (File)
Dec 28 2023, 6:49 PM
Unknown Object (File)
Dec 21 2023, 9:32 PM
Unknown Object (File)
Dec 20 2023, 12:40 AM
Unknown Object (File)
Nov 27 2023, 3:34 AM
Unknown Object (File)
Oct 23 2023, 10:43 AM
View All 38 Files
Subscribers
None

Details

Reviewers
bapt
bdrewery
Summary

Add explicit declaration on needed features and modify code to work with clang. Upstream seems to have gone quiet so, this should be a local patch.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sbruno updated this revision to Diff 1349.Sep 3 2014, 5:35 PM
sbruno retitled this revision from to Remove dependency on gcc.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added a comment.Sep 3 2014, 5:41 PM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193218

sbruno added reviewers: bapt, bdrewery.Sep 10 2014, 4:15 PM
bdrewery requested changes to this revision.Sep 11 2014, 11:19 PM
bdrewery edited edge metadata.

Do you have a log of the build failure? I'm curious to see it.

devel/google-sparsehash/files/patch-src-sparsehash-internal-sparsehashtable.h
8 ↗(On Diff #1349)

It's picky, but can you fix the indentation for all of these changes? Will make it easier to upstream.

This revision now requires changes to proceed.Sep 11 2014, 11:19 PM
sbruno added a comment.Sep 11 2014, 11:41 PM

I can make one, but I don't have one. :-)

This is of interest to me two-fold, its a dependency for clementine-player and its allows a package to be built on ARM

sbruno added a comment.Sep 13 2014, 3:32 PM

https://people.freebsd.org/~sbruno/google-sparsehash-clang.txt

Failure if trying to build with clang

sbruno updated this revision to Diff 1611.Sep 13 2014, 4:30 PM
sbruno edited edge metadata.

Patch cleanup and whitespace things

bdrewery accepted this revision.Sep 15 2014, 3:29 PM
bdrewery edited edge metadata.

Approved. You can also add 'Approved by: maintainer timeout'

This revision is now accepted and ready to land.Sep 15 2014, 3:29 PM
sbruno closed this revision.Sep 15 2014, 3:35 PM

Committed at svn r368270

Revision Contents
Changeset List

PathSize
devel/
google-sparsehash/
4 lines
58 lines

Diff 1611

View Options

devel/google-sparsehash/Makefile

Loading...
View Options

devel/google-sparsehash/files/

Loading...
View Options

devel/google-sparsehash/files/patch-src__sparsehash__internal__sparsehashtable.h

Loading...