Differential D52145

sysutils/slurm-wlm: Fix missing sun_len sin_len and sin6_len on bind() and connect() calls
ClosedPublic
Actions

Authored by rikka.goering_outlook.de on Aug 25 2025, 4:06 AM.

Tags

None

Referenced Files

	F133111904: D52145.id161490.diff
	Thu, Oct 23, 2:03 AM

	Unknown Object (File)
	Sat, Oct 11, 5:40 AM

	Unknown Object (File)
	Sat, Oct 11, 5:40 AM

	Unknown Object (File)
	Sat, Oct 11, 5:40 AM

	Unknown Object (File)
	Sat, Oct 11, 5:40 AM

	Unknown Object (File)
	Sat, Oct 11, 5:40 AM

	Unknown Object (File)
	Fri, Oct 10, 10:29 PM

	Unknown Object (File)
	Wed, Oct 8, 9:32 PM

View All 27 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Contributor Reviewers (ports)

Commits

R11:c2117c1c03b3: sysutils/slurm-wlm: Fix slurmd and slurmstepd crash due to missing sockaddr…

Summary

Added multiple patches to fix sun_len, sin_len and sin6_len not being passed to bind() and connect()
This behavior is acceptable on Linux, but illegal on FreeBSD -> causes disconnects
QA: poudriere testport 14.3-RELEASE amd64: OK; portlint clean; runtime: slurmctld+slurmd start and can hold connection

PR: 288983
Maintainer: rikka.goering@outlook.de

Test Plan

poudriere testport 14.3-RELEASE amd64: OK; portlint clean; runtime: slurmctld+slurmd start and can hold connection

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 66498
Build 63381: arc lint + arc unit

Event Timeline

rikka.goering_outlook.de requested review of this revision.Aug 25 2025, 4:06 AM

rikka.goering_outlook.de created this revision.

Harbormaster completed remote builds in B66498: Diff 160914.Aug 25 2025, 4:06 AM

rikka.goering_outlook.de added a subscriber: thierry.Aug 27 2025, 1:41 AM

Updating D52145: sysutils/slurm-wlm: Fix missing sun_len sin_len and sin6_len on bind() and connect() calls #
Enter a brief description of the changes included in this update.
The first line is used as subject, next lines as comment. #
If you intended to create a new revision, use:
$ arc diff --create
Removed leftover changes from another patch, according to Committer suggestion (see PR: 288983)

Differential Revision: https://reviews.freebsd.org/D52145

Harbormaster completed remote builds in B66809: Diff 161490.Sep 4 2025, 6:46 AM

Removed leftover bind() call outside of #ifdef FreeBSD safeguards, according to committer suggestion (see PR: 288983)
Fixed similar mistakes, noticed during reworking of the patch
Further polished patch and corrected styling

Harbormaster completed remote builds in B66835: Diff 161569.Sep 5 2025, 4:05 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2025, 11:19 AM

Closed by commit R11:c2117c1c03b3: sysutils/slurm-wlm: Fix slurmd and slurmstepd crash due to missing sockaddr… (authored by rikka.goering_outlook.de, committed by vvd). · Explain Why

This revision was automatically updated to reflect the committed changes.

vvd added a commit: R11:c2117c1c03b3: sysutils/slurm-wlm: Fix slurmd and slurmstepd crash due to missing sockaddr….

Revision Contents
Changeset List

Path

Size

sysutils/

slurm-wlm/

files/

patch-configure

2 lines

patch-src_common_conmgr.c

45 lines

patch-src_common_net.c

69 lines

patch-src_common_sack__api.c

30 lines

patch-src_common_slurm__protocol__socket.c

110 lines

patch-src_common_stepd__api.c

36 lines

patch-src_common_xsystemd.c

38 lines

patch-src_plugins_auth_slurm_sack.c

19 lines

patch-src_plugins_task_Makefile.in

20 lines

patch-src_slurmd_slurmstepd_req.c

20 lines

Diff 160914

sysutils/slurm-wlm/files/patch-configure

Loading...

sysutils/slurm-wlm/files/patch-src_common_conmgr.c

Loading...

sysutils/slurm-wlm/files/patch-src_common_net.c

Loading...

sysutils/slurm-wlm/files/patch-src_common_sack__api.c

Loading...

sysutils/slurm-wlm/files/patch-src_common_slurmprotocolsocket.c

Loading...

sysutils/slurm-wlm/files/patch-src_common_stepd__api.c

Loading...

sysutils/slurm-wlm/files/patch-src_common_xsystemd.c

Loading...

sysutils/slurm-wlm/files/patch-src_plugins_auth_slurm_sack.c

Loading...

sysutils/slurm-wlm/files/patch-src_plugins_task_Makefile.in

Loading...

sysutils/slurm-wlm/files/patch-src_slurmd_slurmstepd_req.c

Loading...