Page MenuHomeFreeBSD

Allwinner MP merge a20_mp_start_ap and a31_mp_start_ap
ClosedPublic

Authored by manu on May 9 2016, 3:34 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Dec 8, 3:49 PM
Unknown Object (File)
Thu, Nov 28, 3:04 AM
Unknown Object (File)
Nov 24 2024, 3:19 PM
Unknown Object (File)
Nov 7 2024, 3:33 PM
Unknown Object (File)
Oct 1 2024, 8:16 PM
Unknown Object (File)
Oct 1 2024, 7:26 PM
Unknown Object (File)
Sep 24 2024, 9:20 AM
Unknown Object (File)
Sep 18 2024, 10:07 AM

Details

Summary

Merge a20_mp_start_ap and a31_mp_start_ap into one function.
This function works with all smp non-multicluster allwinner SoC (A20, A31, A31S and H3).

Test Plan

Tested on A20 and A31S

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3632
Build 3672: arc lint + arc unit

Event Timeline

manu retitled this revision from to Allwinner MP merge a20_mp_start_ap and a31_mp_start_ap.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
jmcneill added inline comments.
sys/arm/allwinner/aw_mp.c
200

Unmapping the same handle twice, this should be prcm instead?

sys/arm/allwinner/aw_mp.c
200

Damn, yeah, let me fix this ...

Unmap prcm and not cpucfg a second time.

manu marked 2 inline comments as done.May 9 2016, 4:06 PM
sys/arm/allwinner/aw_mp.c
114

Do you still need to initialize this to 0? You test soc_family later on instead of prcm now.

No need to initialize prcm variable.

manu marked an inline comment as done.May 9 2016, 4:26 PM
sys/arm/allwinner/aw_mp.c
124

Should be } else { on a single line.

manu marked an inline comment as done.May 10 2016, 3:38 AM
This revision is now accepted and ready to land.May 10 2016, 8:31 AM
This revision was automatically updated to reflect the committed changes.