Paths

Table of Contentst

Differential D51759

libusb: implement zlp flag in libusb transfer
Needs ReviewPublic
Actions

Authored by aokblast on Wed, Aug 6, 12:58 PM.

Tags

None

Referenced Files

	F126997414: D51759.id.diff
	Tue, Aug 26, 11:04 AM

	F126989587: D51759.id159849.diff
	Tue, Aug 26, 9:08 AM

	Unknown Object (File)
	Mon, Aug 25, 9:07 PM

	Unknown Object (File)
	Mon, Aug 25, 12:36 PM

	Unknown Object (File)
	Mon, Aug 25, 10:41 AM

	Unknown Object (File)
	Mon, Aug 25, 8:12 AM

	Unknown Object (File)
	Sat, Aug 23, 1:40 AM

	Unknown Object (File)
	Thu, Aug 21, 4:46 PM

View All 13 Files

Subscribers

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

The USB protocol defines a Zero-Length Packet (ZLP) to signal the end of
a transfer when the data size is an exact multiple of the Maximum Packet
Size (MPS). Without a ZLP in such cases, the device may not be able to
determine that the transfer has completed.

This flag is added to libusb to allow the user send a ZLP in the end
of libusb_xfer.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 66339
Build 63222: arc lint + arc unit

Event Timeline

aokblast created this revision.Wed, Aug 6, 12:58 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 6, 12:58 PM

aokblast requested review of this revision.Wed, Aug 6, 12:58 PM

Harbormaster completed remote builds in B66010: Diff 159849.Wed, Aug 6, 12:59 PM

Send packet only the multiple of packet

Harbormaster completed remote builds in B66093: Diff 160029.Fri, Aug 8, 7:33 AM

defer zlp check until we can find the xfer

Harbormaster completed remote builds in B66094: Diff 160030.Fri, Aug 8, 7:58 AM

lwhsu added a subscriber: lwhsu.Mon, Aug 18, 6:18 AM

lwhsu added inline comments.

lib/libusb/libusb10.c
1628	should we use `libusb20_tr_get_max_packet_length()` or `libusb20_tr_get_max_total_length()`?

Get correct MPS

Harbormaster completed remote builds in B66339: Diff 160585.Tue, Aug 19, 11:18 AM

Revision Contents
Changeset List

Path

Size

lib/

libusb/

1 line

24 lines

Diff 160585

lib/libusb/libusb.h

Loading...

lib/libusb/libusb10.c

Loading...