Page MenuHomeFreeBSD
Differential D6269

Allwinner MP merge a20_mp_start_ap and a31_mp_start_ap
ClosedPublic
Actions

Authored by manu on May 9 2016, 3:34 PM.
Tags
Referenced Files
F137166549: D6269.id.diff
Fri, Nov 21, 8:28 AM
F137166210: D6269.id16150.diff
Fri, Nov 21, 8:25 AM
F137165629: D6269.id16098.diff
Fri, Nov 21, 8:21 AM
F137165554: D6269.id16067.diff
Fri, Nov 21, 8:20 AM
F137165389: D6269.id16055.diff
Fri, Nov 21, 8:19 AM
F137165372: D6269.id16061.diff
Fri, Nov 21, 8:19 AM
F137164598: D6269.id16067.diff
Fri, Nov 21, 8:13 AM
F137164413: D6269.id16150.diff
Fri, Nov 21, 8:12 AM
View All Files
Subscribers
andrew
imp
jmcneill

Details

Reviewers
jmcneill
Group Reviewers
ARM
Commits
rS299380: Merge a20_mp_start_ap and a31_mp_start_ap into one function.
Summary

Merge a20_mp_start_ap and a31_mp_start_ap into one function.
This function works with all smp non-multicluster allwinner SoC (A20, A31, A31S and H3).

Test Plan

Tested on A20 and A31S

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3630
Build 3670: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 16055.May 9 2016, 3:34 PM
manu retitled this revision from to Allwinner MP merge a20_mp_start_ap and a31_mp_start_ap.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptMay 9 2016, 3:34 PM
jmcneill added a subscriber: jmcneill.May 9 2016, 4:01 PM
jmcneill added inline comments.
sys/arm/allwinner/aw_mp.c
200

Unmapping the same handle twice, this should be prcm instead?

manu added inline comments.May 9 2016, 4:03 PM
sys/arm/allwinner/aw_mp.c
200

Damn, yeah, let me fix this ...

manu updated this revision to Diff 16061.May 9 2016, 4:06 PM

Unmap prcm and not cpucfg a second time.

manu marked 2 inline comments as done.May 9 2016, 4:06 PM
jmcneill added inline comments.May 9 2016, 4:08 PM
sys/arm/allwinner/aw_mp.c
114

Do you still need to initialize this to 0? You test soc_family later on instead of prcm now.

manu updated this revision to Diff 16067.May 9 2016, 4:25 PM

No need to initialize prcm variable.

manu marked an inline comment as done.May 9 2016, 4:26 PM
jmcneill added inline comments.May 9 2016, 4:28 PM
sys/arm/allwinner/aw_mp.c
124

Should be } else { on a single line.

manu updated this revision to Diff 16098.May 10 2016, 3:38 AM

Fix style(9)

manu marked an inline comment as done.May 10 2016, 3:38 AM
jmcneill accepted this revision.May 10 2016, 8:31 AM
jmcneill added a reviewer: jmcneill.
This revision is now accepted and ready to land.May 10 2016, 8:31 AM
Closed by commit rS299380: Merge a20_mp_start_ap and a31_mp_start_ap into one function. (authored by manu). · Explain WhyMay 10 2016, 6:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
6 lines
3 lines
62 lines

Diff 16055

View Options

sys/arm/allwinner/allwinner_machdep.c

Loading...
View Options

sys/arm/allwinner/aw_mp.h

Loading...
View Options

sys/arm/allwinner/aw_mp.c

Loading...