Page MenuHomeFreeBSD
Differential D6251

Add initial support for Broadcom MIPS processor
ClosedPublic
Actions

Authored by mizhka on May 6 2016, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 2:56 AM
Unknown Object (File)
Sat, Mar 8, 8:50 AM
Unknown Object (File)
Thu, Mar 6, 8:23 PM
Unknown Object (File)
Thu, Feb 27, 5:31 AM
Unknown Object (File)
Wed, Feb 26, 4:48 PM
Unknown Object (File)
Feb 19 2025, 1:50 AM
Unknown Object (File)
Feb 18 2025, 3:04 PM
Unknown Object (File)
Feb 17 2025, 2:24 AM
View All Files
Subscribers
imp
landon_landonf.org
sobomax

Details

Reviewers
sobomax
adrian
Commits
rS299994: [mips/broadcom] Add initial support for Broadcom MIPS processor
Summary

Relies on BHND(4) driver.

There files contains machine-dependent code for Broadcom MIPS processor and provide UART driver.

Test Plan

Tested on ASUS RT-N16 & RT-N53

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mizhka updated this revision to Diff 15987.May 6 2016, 5:39 PM
mizhka retitled this revision from to Add initial support for Broadcom MIPS processor.
mizhka updated this object.
mizhka edited the test plan for this revision. (Show Details)
mizhka added a reviewer: adrian.
mizhka set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMay 6 2016, 5:39 PM
landon_landonf.org added a subscriber: landon_landonf.org.May 6 2016, 10:59 PM
mizhka updated this revision to Diff 16047.May 9 2016, 10:36 AM
  • add TRAMPLOADADDR into kernel configuration
  • fixed style(9) issues
  • added license info
  • cosmetic changes
mizhka updated this revision to Diff 16060.May 9 2016, 3:54 PM
  • rebased to head
mizhka updated this revision to Diff 16298.May 13 2016, 4:40 PM
mizhka added a reviewer: sobomax.
mizhka added a subscriber: sobomax.
  • renamed sys/dev/bhnd/cores/mips/* to sys/mips/broadcom/*
  • add @sobomax as reviewer
mizhka updated this revision to Diff 16415.May 16 2016, 10:19 PM
  • cosmetic improvements
  • device_identify for UART
Closed by commit rS299994: [mips/broadcom] Add initial support for Broadcom MIPS processor (authored by adrian). · Explain WhyMay 17 2016, 12:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
mips/
broadcom/
221 lines
59 lines
90 lines
44 lines
7 lines
103 lines
78 lines
conf/
93 lines
6 lines

Diff 16047

View Options

sys/mips/broadcom/bcm_machdep.c

Show First 20 Lines • Show All 562 Lines • ▼ Show 20 Lines if (oldcred->cr_svuid != oldcred->cr_uid ||
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY); vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
change_svuid(imgp->newcred, imgp->newcred->cr_uid); change_svuid(imgp->newcred, imgp->newcred->cr_uid);
change_svgid(imgp->newcred, imgp->newcred->cr_gid); change_svgid(imgp->newcred, imgp->newcred->cr_gid);
} }
} }
/* The new credentials are installed into the process later. */ /* The new credentials are installed into the process later. */
/* /*
* Do the best to calculate the full path to the image file.
*/
if (args->fname != NULL && args->fname[0] == '/')
imgp->execpath = args->fname;
else {
VOP_UNLOCK(imgp->vp, 0);
if (vn_fullpath(td, imgp->vp, &imgp->execpath,
&imgp->freepath) != 0)
imgp->execpath = args->fname;
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
}
/*
* If the current process has a special image activator it * If the current process has a special image activator it
* wants to try first, call it. For example, emulating shell * wants to try first, call it. For example, emulating shell
* scripts differently. * scripts differently.
*/ */
error = -1; error = -1;
if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL) if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL)
error = img_first(imgp); error = img_first(imgp);
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines#endif
if (imgp->opened) { if (imgp->opened) {
VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td); VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td);
imgp->opened = 0; imgp->opened = 0;
} }
vput(newtextvp); vput(newtextvp);
vm_object_deallocate(imgp->object); vm_object_deallocate(imgp->object);
imgp->object = NULL; imgp->object = NULL;
/* set new name to that of the interpreter */ /* set new name to that of the interpreter */
NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME, NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME,
kibUnsubmitted
Not Done
Inline Actions

I think you need imgp->execpath = NULL;

kib: I think you need imgp->execpath = NULL;
bdreweryAuthorUnsubmitted
Not Done
Inline Actions

Sure, that would be safest. I think it would always be overwritten above though. I'll add it though.

bdrewery: Sure, that would be safest. I think it would always be overwritten above though. I'll add it…
kibUnsubmitted
Not Done
Inline Actions

At least, it would allow potential imgp consumers to not care about stage of the do_execve() where they act. Either pointer is null, or it points to current path.

kib: At least, it would allow potential imgp consumers to not care about stage of the do_execve()…
UIO_SYSSPACE, imgp->interpreter_name, td); UIO_SYSSPACE, imgp->interpreter_name, td);
args->fname = imgp->interpreter_name; args->fname = imgp->interpreter_name;
goto interpret; goto interpret;
} }
/* /*
* NB: We unlock the vnode here because it is believed that none * NB: We unlock the vnode here because it is believed that none
* of the sv_copyout_strings/sv_fixup operations require the vnode. * of the sv_copyout_strings/sv_fixup operations require the vnode.
*/ */
VOP_UNLOCK(imgp->vp, 0); VOP_UNLOCK(imgp->vp, 0);
/*
* Do the best to calculate the full path to the image file.
*/
if (imgp->auxargs != NULL &&
((args->fname != NULL && args->fname[0] == '/') ||
vn_fullpath(td, imgp->vp, &imgp->execpath, &imgp->freepath) != 0))
imgp->execpath = args->fname;
if (disallow_high_osrel && if (disallow_high_osrel &&
P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) { P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) {
error = ENOEXEC; error = ENOEXEC;
uprintf("Osrel %d for image %s too high\n", p->p_osrel, uprintf("Osrel %d for image %s too high\n", p->p_osrel,
imgp->execpath != NULL ? imgp->execpath : "<unresolved>"); imgp->execpath != NULL ? imgp->execpath : "<unresolved>");
vn_lock(imgp->vp, LK_SHARED | LK_RETRY); vn_lock(imgp->vp, LK_SHARED | LK_RETRY);
goto exec_fail_dealloc; goto exec_fail_dealloc;
▲ Show 20 Lines • Show All 976 Lines • Show Last 20 Lines
View Options

sys/mips/broadcom/bcm_socinfo.h

Show First 20 Lines • Show All 562 Lines • ▼ Show 20 Lines if (oldcred->cr_svuid != oldcred->cr_uid ||
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY); vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
change_svuid(imgp->newcred, imgp->newcred->cr_uid); change_svuid(imgp->newcred, imgp->newcred->cr_uid);
change_svgid(imgp->newcred, imgp->newcred->cr_gid); change_svgid(imgp->newcred, imgp->newcred->cr_gid);
} }
} }
/* The new credentials are installed into the process later. */ /* The new credentials are installed into the process later. */
/* /*
* Do the best to calculate the full path to the image file.
*/
if (args->fname != NULL && args->fname[0] == '/')
imgp->execpath = args->fname;
else {
VOP_UNLOCK(imgp->vp, 0);
if (vn_fullpath(td, imgp->vp, &imgp->execpath,
&imgp->freepath) != 0)
imgp->execpath = args->fname;
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
}
/*
* If the current process has a special image activator it * If the current process has a special image activator it
* wants to try first, call it. For example, emulating shell * wants to try first, call it. For example, emulating shell
* scripts differently. * scripts differently.
*/ */
error = -1; error = -1;
if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL) if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL)
error = img_first(imgp); error = img_first(imgp);
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines#endif
if (imgp->opened) { if (imgp->opened) {
VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td); VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td);
imgp->opened = 0; imgp->opened = 0;
} }
vput(newtextvp); vput(newtextvp);
vm_object_deallocate(imgp->object); vm_object_deallocate(imgp->object);
imgp->object = NULL; imgp->object = NULL;
/* set new name to that of the interpreter */ /* set new name to that of the interpreter */
NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME, NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME,
kibUnsubmitted
Not Done
Inline Actions

I think you need imgp->execpath = NULL;

kib: I think you need imgp->execpath = NULL;
bdreweryAuthorUnsubmitted
Not Done
Inline Actions

Sure, that would be safest. I think it would always be overwritten above though. I'll add it though.

bdrewery: Sure, that would be safest. I think it would always be overwritten above though. I'll add it…
kibUnsubmitted
Not Done
Inline Actions

At least, it would allow potential imgp consumers to not care about stage of the do_execve() where they act. Either pointer is null, or it points to current path.

kib: At least, it would allow potential imgp consumers to not care about stage of the do_execve()…
UIO_SYSSPACE, imgp->interpreter_name, td); UIO_SYSSPACE, imgp->interpreter_name, td);
args->fname = imgp->interpreter_name; args->fname = imgp->interpreter_name;
goto interpret; goto interpret;
} }
/* /*
* NB: We unlock the vnode here because it is believed that none * NB: We unlock the vnode here because it is believed that none
* of the sv_copyout_strings/sv_fixup operations require the vnode. * of the sv_copyout_strings/sv_fixup operations require the vnode.
*/ */
VOP_UNLOCK(imgp->vp, 0); VOP_UNLOCK(imgp->vp, 0);
/*
* Do the best to calculate the full path to the image file.
*/
if (imgp->auxargs != NULL &&
((args->fname != NULL && args->fname[0] == '/') ||
vn_fullpath(td, imgp->vp, &imgp->execpath, &imgp->freepath) != 0))
imgp->execpath = args->fname;
if (disallow_high_osrel && if (disallow_high_osrel &&
P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) { P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) {
error = ENOEXEC; error = ENOEXEC;
uprintf("Osrel %d for image %s too high\n", p->p_osrel, uprintf("Osrel %d for image %s too high\n", p->p_osrel,
imgp->execpath != NULL ? imgp->execpath : "<unresolved>"); imgp->execpath != NULL ? imgp->execpath : "<unresolved>");
vn_lock(imgp->vp, LK_SHARED | LK_RETRY); vn_lock(imgp->vp, LK_SHARED | LK_RETRY);
goto exec_fail_dealloc; goto exec_fail_dealloc;
▲ Show 20 Lines • Show All 976 Lines • Show Last 20 Lines
View Options

sys/mips/broadcom/bcm_socinfo.c

Show First 20 Lines • Show All 562 Lines • ▼ Show 20 Lines if (oldcred->cr_svuid != oldcred->cr_uid ||
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY); vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
change_svuid(imgp->newcred, imgp->newcred->cr_uid); change_svuid(imgp->newcred, imgp->newcred->cr_uid);
change_svgid(imgp->newcred, imgp->newcred->cr_gid); change_svgid(imgp->newcred, imgp->newcred->cr_gid);
} }
} }
/* The new credentials are installed into the process later. */ /* The new credentials are installed into the process later. */
/* /*
* Do the best to calculate the full path to the image file.
*/
if (args->fname != NULL && args->fname[0] == '/')
imgp->execpath = args->fname;
else {
VOP_UNLOCK(imgp->vp, 0);
if (vn_fullpath(td, imgp->vp, &imgp->execpath,
&imgp->freepath) != 0)
imgp->execpath = args->fname;
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
}
/*
* If the current process has a special image activator it * If the current process has a special image activator it
* wants to try first, call it. For example, emulating shell * wants to try first, call it. For example, emulating shell
* scripts differently. * scripts differently.
*/ */
error = -1; error = -1;
if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL) if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL)
error = img_first(imgp); error = img_first(imgp);
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines#endif
if (imgp->opened) { if (imgp->opened) {
VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td); VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td);
imgp->opened = 0; imgp->opened = 0;
} }
vput(newtextvp); vput(newtextvp);
vm_object_deallocate(imgp->object); vm_object_deallocate(imgp->object);
imgp->object = NULL; imgp->object = NULL;
/* set new name to that of the interpreter */ /* set new name to that of the interpreter */
NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME, NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME,
kibUnsubmitted
Not Done
Inline Actions

I think you need imgp->execpath = NULL;

kib: I think you need imgp->execpath = NULL;
bdreweryAuthorUnsubmitted
Not Done
Inline Actions

Sure, that would be safest. I think it would always be overwritten above though. I'll add it though.

bdrewery: Sure, that would be safest. I think it would always be overwritten above though. I'll add it…
kibUnsubmitted
Not Done
Inline Actions

At least, it would allow potential imgp consumers to not care about stage of the do_execve() where they act. Either pointer is null, or it points to current path.

kib: At least, it would allow potential imgp consumers to not care about stage of the do_execve()…
UIO_SYSSPACE, imgp->interpreter_name, td); UIO_SYSSPACE, imgp->interpreter_name, td);
args->fname = imgp->interpreter_name; args->fname = imgp->interpreter_name;
goto interpret; goto interpret;
} }
/* /*
* NB: We unlock the vnode here because it is believed that none * NB: We unlock the vnode here because it is believed that none
* of the sv_copyout_strings/sv_fixup operations require the vnode. * of the sv_copyout_strings/sv_fixup operations require the vnode.
*/ */
VOP_UNLOCK(imgp->vp, 0); VOP_UNLOCK(imgp->vp, 0);
/*
* Do the best to calculate the full path to the image file.
*/
if (imgp->auxargs != NULL &&
((args->fname != NULL && args->fname[0] == '/') ||
vn_fullpath(td, imgp->vp, &imgp->execpath, &imgp->freepath) != 0))
imgp->execpath = args->fname;
if (disallow_high_osrel && if (disallow_high_osrel &&
P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) { P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) {
error = ENOEXEC; error = ENOEXEC;
uprintf("Osrel %d for image %s too high\n", p->p_osrel, uprintf("Osrel %d for image %s too high\n", p->p_osrel,
imgp->execpath != NULL ? imgp->execpath : "<unresolved>"); imgp->execpath != NULL ? imgp->execpath : "<unresolved>");
vn_lock(imgp->vp, LK_SHARED | LK_RETRY); vn_lock(imgp->vp, LK_SHARED | LK_RETRY);
goto exec_fail_dealloc; goto exec_fail_dealloc;
▲ Show 20 Lines • Show All 976 Lines • Show Last 20 Lines
View Options

sys/mips/broadcom/files.broadcom

Show First 20 Lines • Show All 562 Lines • ▼ Show 20 Lines if (oldcred->cr_svuid != oldcred->cr_uid ||
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY); vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
change_svuid(imgp->newcred, imgp->newcred->cr_uid); change_svuid(imgp->newcred, imgp->newcred->cr_uid);
change_svgid(imgp->newcred, imgp->newcred->cr_gid); change_svgid(imgp->newcred, imgp->newcred->cr_gid);
} }
} }
/* The new credentials are installed into the process later. */ /* The new credentials are installed into the process later. */
/* /*
* Do the best to calculate the full path to the image file.
*/
if (args->fname != NULL && args->fname[0] == '/')
imgp->execpath = args->fname;
else {
VOP_UNLOCK(imgp->vp, 0);
if (vn_fullpath(td, imgp->vp, &imgp->execpath,
&imgp->freepath) != 0)
imgp->execpath = args->fname;
vn_lock(imgp->vp, LK_EXCLUSIVE | LK_RETRY);
}
/*
* If the current process has a special image activator it * If the current process has a special image activator it
* wants to try first, call it. For example, emulating shell * wants to try first, call it. For example, emulating shell
* scripts differently. * scripts differently.
*/ */
error = -1; error = -1;
if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL) if ((img_first = imgp->proc->p_sysent->sv_imgact_try) != NULL)
error = img_first(imgp); error = img_first(imgp);
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines#endif
if (imgp->opened) { if (imgp->opened) {
VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td); VOP_CLOSE(newtextvp, FREAD, td->td_ucred, td);
imgp->opened = 0; imgp->opened = 0;
} }
vput(newtextvp); vput(newtextvp);
vm_object_deallocate(imgp->object); vm_object_deallocate(imgp->object);
imgp->object = NULL; imgp->object = NULL;
/* set new name to that of the interpreter */ /* set new name to that of the interpreter */
NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME, NDINIT(&nd, LOOKUP, LOCKLEAF | FOLLOW | SAVENAME,
kibUnsubmitted
Not Done
Inline Actions

I think you need imgp->execpath = NULL;

kib: I think you need imgp->execpath = NULL;
bdreweryAuthorUnsubmitted
Not Done
Inline Actions

Sure, that would be safest. I think it would always be overwritten above though. I'll add it though.

bdrewery: Sure, that would be safest. I think it would always be overwritten above though. I'll add it…
kibUnsubmitted
Not Done
Inline Actions

At least, it would allow potential imgp consumers to not care about stage of the do_execve() where they act. Either pointer is null, or it points to current path.

kib: At least, it would allow potential imgp consumers to not care about stage of the do_execve()…
UIO_SYSSPACE, imgp->interpreter_name, td); UIO_SYSSPACE, imgp->interpreter_name, td);
args->fname = imgp->interpreter_name; args->fname = imgp->interpreter_name;
goto interpret; goto interpret;
} }
/* /*
* NB: We unlock the vnode here because it is believed that none * NB: We unlock the vnode here because it is believed that none
* of the sv_copyout_strings/sv_fixup operations require the vnode. * of the sv_copyout_strings/sv_fixup operations require the vnode.
*/ */
VOP_UNLOCK(imgp->vp, 0); VOP_UNLOCK(imgp->vp, 0);
/*
* Do the best to calculate the full path to the image file.
*/
if (imgp->auxargs != NULL &&
((args->fname != NULL && args->fname[0] == '/') ||
vn_fullpath(td, imgp->vp, &imgp->execpath, &imgp->freepath) != 0))
imgp->execpath = args->fname;
if (disallow_high_osrel && if (disallow_high_osrel &&
P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) { P_OSREL_MAJOR(p->p_osrel) > P_OSREL_MAJOR(__FreeBSD_version)) {
error = ENOEXEC; error = ENOEXEC;
uprintf("Osrel %d for image %s too high\n", p->p_osrel, uprintf("Osrel %d for image %s too high\n", p->p_osrel,
imgp->execpath != NULL ? imgp->execpath : "<unresolved>"); imgp->execpath != NULL ? imgp->execpath : "<unresolved>");
vn_lock(imgp->vp, LK_SHARED | LK_RETRY); vn_lock(imgp->vp, LK_SHARED | LK_RETRY);
goto exec_fail_dealloc; goto exec_fail_dealloc;
▲ Show 20 Lines • Show All 976 Lines • Show Last 20 Lines
View Options

sys/mips/broadcom/std.broadcom

Loading...
View Options

sys/mips/broadcom/uart_bus_chipc.c

Loading...
View Options

sys/mips/broadcom/uart_cpu_chipc.c

Loading...
View Options

sys/mips/conf/BCM

Loading...
View Options

sys/mips/conf/BCM.hints

Loading...