makefs: zfs uberblock location is calculated wrong
ClosedPublic
Actions

Authored by tsoome on Mon, Aug 11, 1:43 PM.

Details

Reviewers

Commits

rG6e25c4321cd5: makefs: zfs uberblock location is calculated wrong

Summary

The shift used to calculate uberblock location depends both
on minimum size (UBERBLOCK_SHIFT) and MAX_UBERBLOCK_SHIFT.
Since makefs defaults to use ashift 12, it incidentally
does get the correct size, but ashift 9 does not work with
current code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66258
Build 63141: arc lint + arc unit

Event Timeline

tsoome created this revision.Mon, Aug 11, 1:43 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptMon, Aug 11, 1:43 PM

tsoome requested review of this revision.Mon, Aug 11, 1:43 PM

Harbormaster completed remote builds in B66163: Diff 160181.Mon, Aug 11, 1:43 PM

tsoome added a reviewer: markj.Mon, Aug 11, 1:44 PM

It'd be nice to have a helper macro for this, basically the same as VDEV_UBERBLOCK_SHIFT but just taking an integer ashift as a parameter. There is already one such macro in OpenZFS, ASHIFT_UBERBLOCK_SHIFT in zhack.c.

This revision is now accepted and ready to land.Tue, Aug 12, 1:22 PM

use ASHIFT_UBERBLOCK_SIZE().

This revision now requires review to proceed.Fri, Aug 15, 7:36 AM

Harbormaster completed remote builds in B66258: Diff 160390.Fri, Aug 15, 7:36 AM

markj accepted this revision.Fri, Aug 15, 11:12 AM

This revision is now accepted and ready to land.Fri, Aug 15, 11:12 AM

Closed by commit rG6e25c4321cd5: makefs: zfs uberblock location is calculated wrong (authored by tsoome). · Explain WhyFri, Aug 15, 12:12 PM

This revision was automatically updated to reflect the committed changes.

tsoome added a commit: rG6e25c4321cd5: makefs: zfs uberblock location is calculated wrong.