Page MenuHomeFreeBSD

krb5: Don't install gssapi.h twice
ClosedPublic

Authored by ivy on Aug 9 2025, 6:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 2:07 AM
Unknown Object (File)
Sat, Oct 11, 3:15 AM
Unknown Object (File)
Sat, Oct 11, 3:15 AM
Unknown Object (File)
Sat, Oct 11, 3:15 AM
Unknown Object (File)
Fri, Oct 10, 8:24 PM
Unknown Object (File)
Tue, Oct 7, 4:38 AM
Unknown Object (File)
Thu, Oct 2, 8:29 PM
Unknown Object (File)
Mon, Sep 22, 3:23 PM
Subscribers

Details

Summary
Currently we install /usr/include/gssapi/gssapi.h twice, once in
krb5/include/gssapi and once in krb5/lib/gssapi.

The version in krb5/include/gssapi is wrong: make searches ${.PATH} and
picks crypto/krb5/src/include/gssapi.h to install, but this is the file
which is supposed to be installed in /usr/include/gssapi.h.

The problem was masked by the fact that we install the correct
gssapi/gssapi.h later in krb5/lib/gssapi.

Remove gssapi.h and the unneeded ${.PATH} entry from krb/include/gssapi
and while here, remove the unused GSSAPI_KRB5 include group.

This change does not affect the ultimate result of installworld,
it just avoids installing the same file twice with different content.

PR:     288594

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66129
Build 63012: arc lint + arc unit

Event Timeline

ivy requested review of this revision.Aug 9 2025, 6:10 AM

I would title this “krb5: Don't install gssapi.h twice”

ivy retitled this revision from krb5/include/gssapi: Don't install gssapi.h to krb5: Don't install gssapi.h twice.Aug 10 2025, 12:59 AM

that seems reasonable, i will rewrite the commit message to match.

This revision is now accepted and ready to land.Aug 10 2025, 10:25 AM

LGTM. This is about what I was going to do, except I couldn't figure out which gssapi.h to not install.

Thanks!

This revision was automatically updated to reflect the committed changes.