go-perf: update default website to go.dev
ClosedPublic
Actions

Authored by mengzhuo1203_gmail.com on May 29 2025, 8:37 AM.

Details

Reviewers

adamw
bapt
arrowd

Commits

R11:0edd2ff108ef: lang/go123: Update to 1.23.12
R11:d9314a4f598e: lang/go124: Update to 1.24.6

Summary

The original golang.org has been deprecated, all links has been redirected to go.dev

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mengzhuo1203_gmail.com requested review of this revision.May 29 2025, 8:37 AM

mengzhuo1203_gmail.com created this revision.

mengzhuo1203_gmail.com added reviewers: adamw, bapt, arrowd.May 29 2025, 8:40 AM

Good catch! I'm definitely in favor of switching, but:

1. They'll need to leave the server up for basically ever because of all the programs and libraries depending on packages in the golang.org namespace
That URL has to be mentioned in more than just the lang/go* Makefiles. Have you checked for other Makefiles, pkg-descrs, pkg-message, pkg-message.in, etc? I fully agree about switching to go.dev, but it'd be a long-term win to switch the tree as a whole.

In D50595#1155303, @adamw wrote:

Good catch! I'm definitely in favor of switching, but:

They'll need to leave the server up for basically ever because of all the programs and libraries depending on packages in the golang.org namespace

That URL has to be mentioned in more than just the lang/go* Makefiles. Have you checked for other Makefiles, pkg-descrs, pkg-message, pkg-message.in, etc? I fully agree about switching to go.dev, but it'd be a long-term win to switch the tree as a whole.

Thanks for review,
This change only affect download source code and binary for go itself.
The https://golang.org/dl/*.src.tar.gz redirect (HTTP 301) to go.dev/dl then Google blob file server.

Other golang.org namespace library (golang.org/x) won't change AFAIK.

In D50595#1155305, @mengzhuo1203_gmail.com wrote:

Thanks for review,
This change only affect download source code and binary for go itself.
The https://golang.org/dl/*.src.tar.gz redirect (HTTP 301) to go.dev/dl then Google blob file server.

Other golang.org namespace library (golang.org/x) won't change AFAIK.

I was unclear before: I'm saying that other ports need this change too. "golang.org" appears in some pkg-descr files, it appears in WWW in a number of ports, it appears in Mk/Uses/go.mk, etc.

Before approving and committing this patch, I wanted to encourage you to take a stab at extending this change for other ports too, if you're interested.

In D50595#1155312, @adamw wrote:

In D50595#1155305, @mengzhuo1203_gmail.com wrote:

Thanks for review,
This change only affect download source code and binary for go itself.
The https://golang.org/dl/*.src.tar.gz redirect (HTTP 301) to go.dev/dl then Google blob file server.

Other golang.org namespace library (golang.org/x) won't change AFAIK.

I was unclear before: I'm saying that other ports need this change too. "golang.org" appears in some pkg-descr files, it appears in WWW in a number of ports, it appears in Mk/Uses/go.mk, etc.

Before approving and committing this patch, I wanted to encourage you to take a stab at extending this change for other ports too, if you're interested.

Thanks for review, I use p5-ack to search "https://golang.org", and find two more matches than the first diff.

@adamw Hi, is my patch OK or do I need more work on it?

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Aug 6, 11:59 PM

Closed by commit R11:d9314a4f598e: lang/go124: Update to 1.24.6 (authored by adamw). · Explain Why

This revision was automatically updated to reflect the committed changes.

adamw added a commit: R11:d9314a4f598e: lang/go124: Update to 1.24.6.

adamw added a commit: R11:0edd2ff108ef: lang/go123: Update to 1.23.12.Thu, Aug 7, 12:12 AM

Sorry about the really long silence there. I rolled this into today's updates to go124 and go123. I opted not to change anything lower than that because those ports are EOL upstream and shouldn't exist (it's my fault that they still do). Thank you for submitting this!

Please remember to MFH these updates so that Go ports in the quarterly branch too get security updates!