Page MenuHomeFreeBSD

CONTRIBUTING: Tweak the language
ClosedPublic

Authored by imp on Wed, Jul 30, 6:53 PM.
Tags
None
Referenced Files
F127059566: D51638.id159821.diff
Wed, Aug 27, 3:22 AM
F127033914: D51638.diff
Tue, Aug 26, 7:39 PM
F127023847: D51638.diff
Tue, Aug 26, 4:57 PM
F127023757: D51638.diff
Tue, Aug 26, 4:55 PM
F127016673: D51638.diff
Tue, Aug 26, 3:21 PM
F127008324: D51638.diff
Tue, Aug 26, 1:36 PM
Unknown Object (File)
Mon, Aug 25, 3:22 AM
Unknown Object (File)
Sun, Aug 24, 2:05 PM
Subscribers

Details

Summary

Tweak the language around several items, as well as making things less
overly verbose.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65993
Build 62876: arc lint + arc unit

Event Timeline

imp requested review of this revision.Wed, Jul 30, 6:53 PM
imp created this revision.

tweak based on some text ed shared from a git pull request for the git project.

small tweaks to include chosen name and restructure run-on senentences.

"Chosen name" is the term used by people who are changing their name legally,
but haven't yet finished the paperwork. It differs from "Preferred name" which
would be "Warner Losh" in my case, rather than "Michael Warner Losh" which is my
full, legal name. Other examples of the latter for me might be could also be
"Waldo Losh" or similar. A pseudonym in my case might be "Norman T Red" or
"Orange Swirl". If I hated my name and intended to change it to "Henry
Standward", then that would be a chosen name.

I do realize there's some discomfort that these terms may generate in some contexts, but we do need to clarify different nuances of name and that so long as the identiy used meets the minimal criteria, it's all good.

jhb added inline comments.
CONTRIBUTING.md
109

tiny tweaks: one from jhb, one suggested by a friend.

add back accidentally dropped text about git being immutable.

update, per irc feedback...

finaly tweaks...

Use "full name: is the preferred term to refer to the name one normally uses for
contracts, etc. Legal name doesn't have a good, universal meaning. Some states
have it, some countries have it, most have a common law notion that
non-fraudulent use establishes the name (though it can get complicated from
there). Instead simply state that the name need not match relevant government
documents and leave it at that. Asset ownership is a weird and wonderful area of
law where one may hold assets under a variety of names. Since many changes
contain copyrighted material to the project, and that's an asset, being overly
specific can cause more problems than it solves. Unlike binary bits, there's no
bright lines or one true answers here, especially for an international audience.
I personally own assets in about 6 different names (all variations of the name
that relevant government documents state).

des added inline comments.
CONTRIBUTING.md
105

I would remove “Git” here since the policy is orthogonal to the tool.

116

I would consider adding a paragraph about .mailmap and what to do if you've submitted changes under a different name in the past.

CONTRIBUTING.md
105

True. This was in there originally as 'git history' because it is immutable. svn could, theoretically, be changed, but practically couldn't (since the svn mirror program would do random, weird things when you did, so de-facto you couldn't for our usecase: for git nobody can). I'll remove it.

116

Not here. This isn't the place to describe how we implement things. It's more for the committer handbook since it's a thing we do inside the project (and should do with new committers and/or old ones that want a new address) and ti fix oopses, and getting into all that here wouldn't be on point. This is how to contribute, not how we manage the details.

CONTRIBUTING.md
116

Hmm, but I can mention it in passing in an earlier paragraph, though.

CONTRIBUTING.md
111

missing verb

116

.mailmap isn't just for committers, it's for non-committer authors too, just look at its current contents...

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Aug 8, 5:18 PM
This revision was automatically updated to reflect the committed changes.